Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removed incorrect specification for node id in receipt #16622

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsync-swirlds
Copy link
Member

@jsync-swirlds jsync-swirlds commented Nov 15, 2024

Very small update to fix some documentation-only errors in the protocol buffer specification for Node update/delete and transaction receipt.

Fixes #16595

@jsync-swirlds jsync-swirlds self-assigned this Nov 15, 2024
@jsync-swirlds jsync-swirlds added the Dynamic Address Book All issues related to dynamic address book label Nov 15, 2024
@jsync-swirlds jsync-swirlds added this to the v0.57 milestone Nov 15, 2024
@jsync-swirlds jsync-swirlds changed the title Removed incorrect specification for node id in receipt docs: Removed incorrect specification for node id in receipt Nov 15, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eb8b444) 96837 62993 65.05%
Head commit (1ce3271) 96837 (+0) 62982 (-11) 65.04% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16622) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.31%. Comparing base (eb8b444) to head (1ce3271).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16622      +/-   ##
=============================================
- Coverage      63.32%   63.31%   -0.01%     
+ Complexity     20140    20134       -6     
=============================================
  Files           2531     2531              
  Lines          94018    94018              
  Branches        9834     9834              
=============================================
- Hits           59539    59530       -9     
- Misses         30887    30898      +11     
+ Partials        3592     3590       -2     

see 12 files with indirect coverage changes

Impacted file tree graph

@jsync-swirlds jsync-swirlds marked this pull request as ready for review November 15, 2024 21:00
@jsync-swirlds jsync-swirlds requested review from a team as code owners November 15, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Address Book All issues related to dynamic address book
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

TransactionReceipt nodeId property doesn't appear to be set properly for DAB transactions
1 participant