TransactionReceipt nodeId property doesn't appear to be set properly for DAB transactions

[jbair06]

Problem

I ran a NodeDelete transaction. I submitted the transaction to node 6 (with account ID 0.0.9). I deleted node 2. The receipt had the nodeId set to 0. After testing a few different times, submitted to different nodes and deleting different nodes, it appears that the nodeId never gets set for the NodeDelete.

Solution

• NodeDelete and NodeUpdate both need to set the nodeId of the affected node.

Alternatives

No response

[jbair06]

After discussion with @iwsimon and @netopyr, the NodeDelete and NodeUpdate receipts do not need to include the nodeId.

The nodeId for these two transactions is similar to the accountId to the account update and delete transactions. Meaning that the account id is not included in the receipt, as it was part of the request. So, too, the nodeId is not needed in the receipt as it is part of the request.

Therefore, the documentation should be updated to reflect this. It current indicates that nodeId should be set for all three node transactions, where it is only actually set for NodeCreate

[SvetBorislavov]

+1

[jsync-swirlds]

HIP update is already in process; proto file update in both repositories will follow soon.