Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Filtered*State and Wrapped*State to swirlds-state-api #16589

Open
Tracked by #15574
imalygin opened this issue Nov 13, 2024 · 0 comments · May be fixed by #16620
Open
Tracked by #15574

Move Filtered*State and Wrapped*State to swirlds-state-api #16589

imalygin opened this issue Nov 13, 2024 · 0 comments · May be fixed by #16620
Assignees
@thenswan
Labels
Platform Tickets pertaining to the platform

Comments

@imalygin
Copy link
Member

imalygin commented Nov 13, 2024 •
edited
Loading

Currently the following list of classes:

FilteredReadableStates
FilteredWritableStates
WrappedReadableKVState
WrappedWritableKVState
WrappedWritableQueueState
WrappedWritableSingletonState

reside in com.hedera.node.app.spi.state of hedera-app-spi module. There is absolutely no reason for these classes to be on the app side, as they don't have anything that is application related. Therefore, they should be moved to the swirlds-state-api module where other *Readable*State and *Writable*State are.
@imalygin imalygin mentioned this issue Nov 13, 2024
Open
@imalygin imalygin added the Platform Tickets pertaining to the platform label Nov 13, 2024
@thenswan thenswan self-assigned this Nov 14, 2024
@thenswan thenswan linked a pull request Nov 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thenswan thenswan

Labels
Platform Tickets pertaining to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move Filtered*State and Wrapped*State to swirlds-state-api hashgraph/hedera-services
2 participants
@imalygin @thenswan