Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MerkleStateLifecycle #16569

Open
Tracked by #15574
imalygin opened this issue Nov 12, 2024 · 0 comments
Open
Tracked by #15574

Rename MerkleStateLifecycle #16569

imalygin opened this issue Nov 12, 2024 · 0 comments

Comments

@imalygin
Copy link
Member

imalygin commented Nov 12, 2024

As #16568 suggests, the platform should not depend on the implementation of the state. And the fact that State is a Merkle tree is that implementation detail. It should removed from the class name. However, the name StateLifecycle would be confusing as well, as the state lifecycle denotes a different thing. Specifically, it can be represented by this diagram:

State_lifecycle drawio (2)

In this case we're dealing with SwirldsState lifecycle. That's, a platform perspective of the state. So, the better name for the interface should be SwirldsStateLifecycle

@imalygin imalygin changed the title Rename `MerkleStateLifecycle Rename MerkleStateLifecycle Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant