-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename any usage of “Hedera”, “Swirlds” or “Hashgraph” to “Hiero” #2017
Comments
The renaming is done for We would need someone from devops to rename the gradle files in order to build the other modules. |
I just noticed that the packages after the rename are This mainly concerns the group defined in settings.gradle.kts:
If that is changed. For consistency I would also
For more context, see this Slack message: https://swirldslabs.slack.com/archives/C058265B2BS/p1736924474202549 NOTE: I only put this comment here so that these things are considered before the final release of |
Hi @jjohannes ,FYI - I am unable to see the slack conversation. |
The message is about the general pattern to name things. Which I wrote down for the hedera-services modules. A good pattern that is commonly used (e.g. by apache libraries) would be to follow this naming scheme consistently:
For example:
Then:
But maybe I am wrong with what I wrote above. Here is no "product name" as there is only one module (sdk). Which is itself the "product". I just remembered a conversation on Slack (hope you can follow this link). That means in
So if we use
That would then lead to:
Then things already fit, despite the change of the group to Sorry for the fuzz. Hope it makes sense. I just would like to make sure this is all correct before the first release with the new name. 😅 |
This is well explained. I would note that there are multiple SDKs. Each language has its own, so we might consider using that as a module name in this layout.
That would then lead to:
I believe this might be more consistent across the full array of tools and projects.
|
That sounds like a good alternative to me. |
Problem
Solution
Alternatives
No response
The text was updated successfully, but these errors were encountered: