build: replace Taskfile with Gradle tasks #2179
Open
+52
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only things in the Taskfile that were still important are the "update*" tasks. All other tasks just forwarded to Gradle. With this change, the "update" tasks are implemented in Gradle so Taskfile (and with that a separate tool) is no longer needed. While testing the "updateProto" task, I discovered that we still missed some adjustments in the "hedera -> hiero" change. These are done in this PR as well. Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes
force-pushed
the
1794-taskfile
branch
from
fe37201 to
d632f6a
Compare
This file is no longer needed. (hiero-ledger/hiero-gradle-conventions#37) Signed-off-by: Jendrik Johannes <[email protected]>
andrewb1269hg
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The only things in the Taskfile that were still important are the update* tasks. All other tasks just forwarded to Gradle.
With this change, the "update" tasks are implemented in Gradle and Taskfile (and with that a separate tool) is no longer needed.
While testing the
updatePrototask, I discovered that we still missed some adjustments in the "hedera -> hiero" change. These are done in this PR as well.Also, remove
developers.properties- see: hiero-ledger/hiero-gradle-conventions#37Related issue(s):
#1794 - addresses open issue: Revisit
Taskfile.yml(maybe make it as gradle tasks)