Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HbarLimiter tests are very flaky #3188

Closed
quiet-node opened this issue Oct 30, 2024 · 0 comments · Fixed by #3189
Closed

HbarLimiter tests are very flaky #3188

quiet-node opened this issue Oct 30, 2024 · 0 comments · Fixed by #3189
Assignees
Labels
Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Milestone

Comments

@quiet-node
Copy link
Member

quiet-node commented Oct 30, 2024

Problem

With the new implementation of HbarLimitService enabled, the HBAR Limiter test has become highly flaky. Since adding expenses and updating spending plans are executed asynchronously, and the suite includes exhaustion tests with numerous consecutive calls to the network, the test client sometimes fails to retrieve the correct amounts. The tests are flaky to the extent that they either fail or only pass after multiple retries.

Alternatives

No response

@quiet-node quiet-node added the Internal For changes that affect the project's internal workings but not its outward-facing functionality. label Oct 30, 2024
@quiet-node quiet-node added this to the 0.60.0 milestone Oct 30, 2024
@quiet-node quiet-node self-assigned this Oct 30, 2024
@quiet-node quiet-node moved this from Backlog to In Review in Smart Contract Sprint Board Oct 30, 2024
@quiet-node quiet-node linked a pull request Oct 31, 2024 that will close this issue
2 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
Status: Done
1 participant