Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the cryptoTransfer method defined in the IHederaTokenService #195

Open
arianejasuwienas opened this issue Jan 15, 2025 · 0 comments · May be fixed by #219
Open

Implement the cryptoTransfer method defined in the IHederaTokenService #195

arianejasuwienas opened this issue Jan 15, 2025 · 0 comments · May be fixed by #219
Assignees
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@arianejasuwienas
Copy link
Contributor

The cryptoTransfer method from the IHederaTokenService interface is a functionality that enables transfers of both HBAR (Hedera’s native cryptocurrency) and tokens (fungible or non-fungible) within the Hedera network.

It requires logic that is not yet present in the IERC721 and IERC20 interfaces, as it processes balance changes for fungible tokens in a different manner. Instead of handling individual transfers with sender, recipient, and amount details, it accounts for the net changes in balances (positive and/or negative) across all accounts. This approach requires ensuring that the overall balances reconcile to zero.

Additionally, it incorporates HBAR transfer functionality.

Interface to implement:

function cryptoTransfer(
    TransferList memory transferList, 
    TokenTransferList[] memory tokenTransfers
) payable htsCall external returns (int64 responseCode)
@arianejasuwienas arianejasuwienas added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jan 15, 2025
@arianejasuwienas arianejasuwienas self-assigned this Jan 15, 2025
@arianejasuwienas arianejasuwienas changed the title Providing an implementation for the cryptoTransfer method defined in the IHederaTokenService interface Implement the cryptoTransfer method defined in the IHederaTokenService interface Jan 15, 2025
@arianejasuwienas arianejasuwienas changed the title Implement the cryptoTransfer method defined in the IHederaTokenService interface Implement the cryptoTransfer method defined in the IHederaTokenService interface Jan 15, 2025
@arianejasuwienas arianejasuwienas changed the title Implement the cryptoTransfer method defined in the IHederaTokenService interface Implement the cryptoTransfer method defined in the IHederaTokenService Jan 15, 2025
arianejasuwienas added a commit that referenced this issue Jan 17, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 22, 2025
arianejasuwienas added a commit that referenced this issue Jan 23, 2025
arianejasuwienas added a commit that referenced this issue Jan 23, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 23, 2025
arianejasuwienas added a commit that referenced this issue Jan 24, 2025
arianejasuwienas added a commit that referenced this issue Jan 24, 2025
arianejasuwienas added a commit that referenced this issue Jan 27, 2025
arianejasuwienas added a commit that referenced this issue Jan 27, 2025
arianejasuwienas added a commit that referenced this issue Jan 27, 2025
…behaves exactly the same in the forked an non-forked network (#195)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 28, 2025
@arianejasuwienas arianejasuwienas linked a pull request Jan 28, 2025 that will close this issue
2 tasks
arianejasuwienas added a commit that referenced this issue Jan 28, 2025
…ng 0x00 value in hardhat (#195)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Status: Backlog
1 participant