Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README documentation incorrect line 169 logit_dim #98

Open
tynanseltzer opened this issue Apr 4, 2019 · 0 comments
Open

README documentation incorrect line 169 logit_dim #98

tynanseltzer opened this issue Apr 4, 2019 · 0 comments

Comments

@tynanseltzer
Copy link
Contributor

On line 169 of README, dist = ntorch.distributions.Categorical(logits=params, logit_dim="logits") is incorrect, in that the keyword is dim_logitas seen on line 27 of namedtensor/distributions/distributions.py. While a simple fix would be changing the README, I actually prefer logit_dim over dim_logit so would prefer changing the keyword. This, however, has issues with backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant