Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add" feature in the admin sometimes appears #85

Open
rebeccacremona opened this issue Aug 31, 2018 · 4 comments
Open

"Add" feature in the admin sometimes appears #85

rebeccacremona opened this issue Aug 31, 2018 · 4 comments

Comments

@rebeccacremona
Copy link
Collaborator

"Add another" should not appear here:
image
When there is a response, it does not:
image

So, something about the code for removing "add" from the UI is not working, when there is a SubscriptionRequest or a UpdateRequest but no matching response.

@rebeccacremona
Copy link
Collaborator Author

I think this may actually be a js issue:
Loading failed for the <script> with source “http://localhost/static/admin/js/jquery.js”.
Loading failed for the <script> with source “https://perma-payments.com/static/admin/js/jquery.min.js”.

@rebeccacremona
Copy link
Collaborator Author

Nope, that's not it, even after fixing jquery load issue.

@rebeccacremona
Copy link
Collaborator Author

new theory max_num_forms should be 0, and is 1

<input name="subscription_request-0-subscription_request_response-MAX_NUM_FORMS" value="1" id="id_subscription_request-0-subscription_request_response-MAX_NUM_FORMS" autocomplete="off" type="hidden">

https://github.com/django/django/blob/1.11.14/django/contrib/admin/static/admin/js/inlines.js#L39

@rebeccacremona
Copy link
Collaborator Author

I think the library I'm using for nested forms is no longer under active development, and it's not going to work, I don't think, with Django 2... so I'm going to have bigger fish to fry :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant