Skip to content
This repository has been archived by the owner on Oct 18, 2018. It is now read-only.

In the merge cells tutorial, use different colspan and rowspan #49

Open
Treppenhouse opened this issue Aug 15, 2017 · 1 comment
Open
Labels

Comments

@Treppenhouse
Copy link

In the merge cells tutorial https://docs.handsontable.com/0.34.0/demo-merged-cells.html you provide three examples for merging cells:

mergeCells: [
      {row: 1, col: 1, rowspan: 3, colspan: 3},
      {row: 3, col: 4, rowspan: 2, colspan: 2},
      {row: 5, col: 6, rowspan: 3, colspan: 3}
    ]

however, in EVERY example the rowspan is exactly equal to the colspan. I think it would be much better if their values differ to show that this is a possibility, too. And to show which of the two parameter has what effect.

For example:

mergeCells: [
      {row: 1, col: 1, rowspan: 4, colspan: 1},
      {row: 3, col: 4, rowspan: 2, colspan: 2},
      {row: 5, col: 6, rowspan: 2, colspan: 5}
    ]
@AMBudnik
Copy link

That's an interesting observation @Treppenhouse
It has been added so long time ago and we did not even think that this may look strange. But I guess you're right, it would look better if the rowspan and colspan values differ,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants