Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window.js: The way we set height for windows should be improved #1430

Open
jacobwod opened this issue Nov 3, 2023 · 0 comments
Open

Window.js: The way we set height for windows should be improved #1430

jacobwod opened this issue Nov 3, 2023 · 0 comments
Labels

Comments

@jacobwod
Copy link
Member

jacobwod commented Nov 3, 2023

Admin UI gives three options when setting height for a plugin's window:

  • "auto" - seems to mean "max height" in this case…
  • "dynamic" - tries to adapt the height to window's content
  • a fixed numeric value, in pixels

Unfortunately, what happens thereafter is rather confusing. See screenshot below that shows the different values from Admin UI and how they translate into state variables in Window.js:

Skärmavbild 2023-11-03 kl  09 32 05

Seems related to: #1375 and #1428

@jacobwod jacobwod added the bug label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Approved ideas
Development

No branches or pull requests

1 participant