Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters + search to admin hackathons page #262

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add filters + search to admin hackathons page #262

wants to merge 4 commits into from
+30 −2

Conversation

cjdenio
Copy link
Member

@cjdenio cjdenio commented Oct 20, 2023

Screenshot 2023-10-20 at 1 46 16 PM

northeastprince
northeastprince reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@northeastprince northeastprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to consider using Postgres' search functionality for this.

app/controllers/admin/hackathons_controller.rb Outdated Show resolved Hide resolved
app/views/admin/hackathons/index.html.erb Outdated Show resolved Hide resolved
This was linked to issues Oct 28, 2023
Dashboard: Filter & sort hackathons on list view #33
Open
Dashboard: Search by hackathon names #200
Open
@northeastprince northeastprince changed the title Add filters to admin hackathons page Add filters + search to admin hackathons page Oct 28, 2023
@northeastprince
Copy link
Collaborator

northeastprince commented Nov 11, 2023 •
edited
Loading

So it seems like full-text search won't work perfectly with names like TestHacks vs Test Hacks. I still think it'd be better cause we're able to use indexes, but maybe there's a way to automatically separate names by capital letters and include those in the tsvector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@northeastprince northeastprince northeastprince left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard: Search by hackathon names Dashboard: Filter & sort hackathons on list view
2 participants
@cjdenio @northeastprince