Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement updateHeader function for Gcp Events Filter #3

Open
h9jiang opened this issue Aug 20, 2020 · 1 comment
Open

Implement updateHeader function for Gcp Events Filter #3

h9jiang opened this issue Aug 20, 2020 · 1 comment
Assignees
@h9jiang

Comments

@h9jiang
Copy link
Owner

h9jiang commented Aug 20, 2020 •
edited
Loading

Update Header functionality:
After receiving HttpRequest unbinded from SDK, update incoming HTTP request accordingly.

For PR#3, the detail logic for updateHeader function has not be implemented yet. It only returns absl::OkStatus() and do nothing.
Please checkout PR#3 for more detail.
@h9jiang h9jiang self-assigned this Aug 20, 2020
@h9jiang
Copy link
Owner Author

h9jiang commented Aug 20, 2020 •
edited
Loading

For PR#6, the dependency of HttpRequest (boost beast) has been successfully imported into Envoy. So the detail logic for updateHeader function has been implemented.

updateHeader takes an HttpRequest as input parameter and update the previous saved header accordingly.

But for now, the input HttpRequest is still a dummy request that is previous determined. Still need to wait for CloudEvents SDK to be imported to Envoy

hrasadi added a commit that referenced this issue Sep 8, 2020
@hrasadi
Merge pull request #3 from h9jiang/logic
e50f31e 
Logic framework for Gcp Events Convert filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h9jiang h9jiang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h9jiang