Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar dropdown display #545

Open
alepbloyd opened this issue Apr 10, 2024 · 1 comment
Open

Fix search bar dropdown display #545

alepbloyd opened this issue Apr 10, 2024 · 1 comment

Comments

@alepbloyd
Copy link
Contributor

If a user is logged in, they can select from different pools to search from (All of GW ScholarSpace, My Works, My Collections).

Screen Shot 2024-04-10 at 5 05 03 PM

No matter which of these you select, the dropdown indicator still says All, but it does properly change the search behavior.

@maxturer - Tagging you since you probably have most familiarity with this, but no idea how simple/complex a fix it'll turn out to be.

@maxturer
Copy link
Contributor

Solved this: Span element for the button is missing data-search-element="label" (the screenreadee only element has this already and changes accordingly). Adding this fixes the issue, so I'll add it to upcoming misc PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants