Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables are not escaped properly #9

Open
TheAssassin opened this issue Oct 13, 2017 · 2 comments
Open

Variables are not escaped properly #9

TheAssassin opened this issue Oct 13, 2017 · 2 comments

Comments

@TheAssassin
Copy link
Contributor

While creating #8, I fixed some of the variable occurrences with improper escaping. The scripts should be revised, and the variables should be escaped appropriately. This is probably quite some work, but should prevent the usual annoyances (like "there must be no space in the paths" etc.).

@guysoft
Copy link
Owner

guysoft commented Oct 13, 2017

Would appreciate it if anyone wants to take this endeavor. It sorta works for me and there might be there someone who is better in Bash coding conventions. @shlomif I remember you were pretty good at it. If you have any pointers that would be appropriated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants