From d4303332457f5822b5f680a60d6fe00dfe25db40 Mon Sep 17 00:00:00 2001
From: yaozm <ityaozm@gmail.com>
Date: Fri, 10 May 2024 11:40:13 +0800
Subject: [PATCH] refactor(test): Improve env_explode test case

- Updated the test case for env_explode function in HeplersTest.php
- Changed the expectation for env_explode('ENV_EXPLODE_EMPTY') to an empty array
---
 phpstan-baseline.neon                |  5 +++
 phpunit.xml.dist                     |  6 ++--
 rector.php                           | 11 ++----
 src/Support/helpers.php              |  2 +-
 tests/Commands/TestCommandTest.php   | 22 +++++++++---
 tests/ExceptionNotifyManagerTest.php | 10 +++---
 tests/Pest.php                       | 54 ++++++++++++++++++++++++----
 tests/Support/HeplersTest.php        |  2 +-
 tests/TestCase.php                   |  1 +
 9 files changed, 84 insertions(+), 29 deletions(-)

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
index 4025d49..021462b 100644
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@@ -5,6 +5,11 @@ parameters:
 			count: 1
 			path: src/Collectors/ApplicationCollector.php
 
+		-
+			message: "#^Call to an undefined method Illuminate\\\\Contracts\\\\Foundation\\\\Application\\:\\:terminating\\(\\)\\.$#"
+			count: 1
+			path: src/Commands/TestCommand.php
+
 		-
 			message: "#^Method Guanguans\\\\LaravelExceptionNotify\\\\DefaultNotifyClientExtender\\:\\:__invoke\\(\\) should return Guanguans\\\\Notify\\\\Foundation\\\\Client but returns Guanguans\\\\Notify\\\\Foundation\\\\Concerns\\\\HasHttpClient\\.$#"
 			count: 1
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 7c4f77a..de09bd5 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -25,11 +25,11 @@
   </testsuites>
   <php>
     <env name="APP_KEY" value="base64:e2ASw7JCNMYR6PWInGGQrzUzisuDvv8bhNl14XGbUi8="/>
-    <env name="ENV_EXPLODE_STRING" value="log,null"/>
-    <env name="ENV_EXPLODE_TRUE" value="true"/>
-    <env name="ENV_EXPLODE_FALSE" value="false"/>
     <env name="ENV_EXPLODE_EMPTY" value="empty"/>
+    <env name="ENV_EXPLODE_FALSE" value="false"/>
     <env name="ENV_EXPLODE_NULL" value="null"/>
+    <env name="ENV_EXPLODE_STRING" value="log,null"/>
+    <env name="ENV_EXPLODE_TRUE" value="true"/>
   </php>
   <!--<listeners>
     <listener class="JohnKary\PHPUnit\Listener\SpeedTrapListener">
diff --git a/rector.php b/rector.php
index d77503b..a700f72 100644
--- a/rector.php
+++ b/rector.php
@@ -163,6 +163,7 @@
     ])
     ->withSkip([
         EncapsedStringsToSprintfRector::class,
+        ExplicitBoolCompareRector::class,
         ExplicitReturnNullRector::class,
         LogicalToBooleanRector::class,
         NewlineAfterStatementRector::class,
@@ -174,20 +175,14 @@
         DisallowedEmptyRuleFixerRector::class => [
             // __DIR__.'/src/Support/QueryAnalyzer.php',
         ],
-        ExplicitBoolCompareRector::class => [
-            // __DIR__.'/src/JavascriptRenderer.php',
-        ],
         RemoveExtraParametersRector::class => [
             // __DIR__.'/src/Macros/QueryBuilderMacro.php',
         ],
         RenameForeachValueVariableToMatchExprVariableRector::class => [
             // __DIR__.'/src/OutputManager.php',
         ],
-        StaticArrowFunctionRector::class => [
-            __DIR__.'/tests/ExceptionNotifyManagerTest.php',
-        ],
-        StaticClosureRector::class => [
-            __DIR__.'/src/ReportUsingCreator.php',
+        StaticArrowFunctionRector::class => $staticClosureSkipPaths = [
             __DIR__.'/tests',
         ],
+        StaticClosureRector::class => $staticClosureSkipPaths,
     ]);
diff --git a/src/Support/helpers.php b/src/Support/helpers.php
index 5b01b55..c73bd12 100644
--- a/src/Support/helpers.php
+++ b/src/Support/helpers.php
@@ -72,7 +72,7 @@ function env_explode(string $key, $default = null, string $delimiter = ',', int
         $env = env($key, $default);
 
         if (\is_string($env)) {
-            return explode($delimiter, $env, $limit);
+            return $env ? explode($delimiter, $env, $limit) : [];
         }
 
         return $env;
diff --git a/tests/Commands/TestCommandTest.php b/tests/Commands/TestCommandTest.php
index 9bfbc21..b4d3d58 100644
--- a/tests/Commands/TestCommandTest.php
+++ b/tests/Commands/TestCommandTest.php
@@ -18,11 +18,25 @@
 use Symfony\Component\Console\Command\Command;
 use function Pest\Laravel\artisan;
 
-it('can test for exception-notify', function (): void {
+it('can test for exception-notify when is not enabled', function (): void {
     config()->set('exception-notify.enabled', false);
-    artisan(TestCommand::class)->assertExitCode(Command::SUCCESS);
-})->group(__DIR__, __FILE__)->skip();
+    artisan(TestCommand::class)->assertExitCode(Command::INVALID);
+})->group(__DIR__, __FILE__);
+
+it('can test for exception-notify when default channels is empty', function (): void {
+    config()->set('exception-notify.defaults', []);
+    artisan(TestCommand::class)->assertExitCode(Command::INVALID);
+})->group(__DIR__, __FILE__);
+
+it('can test for exception-notify when should not report', function (): void {
+    \Guanguans\LaravelExceptionNotify\Facades\ExceptionNotify::skipWhen(
+        static fn (\Throwable $throwable): bool => $throwable instanceof RuntimeException
+    );
+    artisan(TestCommand::class)->assertExitCode(Command::INVALID);
+})->group(__DIR__, __FILE__);
 
 it('will throws RuntimeException', function (): void {
-    artisan(TestCommand::class);
+    artisan(TestCommand::class, [
+        '--channels' => ['bark', 'log'],
+    ]);
 })->group(__DIR__, __FILE__)->throws(RuntimeException::class, 'Test for exception-notify.');
diff --git a/tests/ExceptionNotifyManagerTest.php b/tests/ExceptionNotifyManagerTest.php
index 049c829..9a279a0 100644
--- a/tests/ExceptionNotifyManagerTest.php
+++ b/tests/ExceptionNotifyManagerTest.php
@@ -66,10 +66,6 @@
         ->report(new RuntimeException)->toBeNull();
 })->group(__DIR__, __FILE__);
 
-it('should report', function (): void {
-    expect(app(ExceptionNotifyManager::class))->shouldReport(new RuntimeException)->toBeTrue();
-})->group(__DIR__, __FILE__);
-
 it('should not report', function (): void {
     config()->set('exception-notify.enabled', false);
     expect(app(ExceptionNotifyManager::class))->shouldReport(new RuntimeException)->toBeFalse();
@@ -88,7 +84,11 @@
         );
     });
     expect(app(ExceptionNotifyManager::class))->shouldReport(new RuntimeException)->toBeFalse();
-})->group(__DIR__, __FILE__)->depends('it should report');
+})->group(__DIR__, __FILE__);
+
+it('should report', function (): void {
+    expect(app(ExceptionNotifyManager::class))->shouldReport(new RuntimeException)->toBeTrue();
+})->group(__DIR__, __FILE__);
 
 it('can get default driver', function (): void {
     expect(app(ExceptionNotifyManager::class))
diff --git a/tests/Pest.php b/tests/Pest.php
index 6546198..9969ca6 100644
--- a/tests/Pest.php
+++ b/tests/Pest.php
@@ -1,5 +1,7 @@
 <?php
 
+/** @noinspection PhpUnused */
+/** @noinspection PhpUndefinedClassInspection */
 /** @noinspection AnonymousFunctionStaticInspection */
 /** @noinspection StaticClosureCanBeUsedInspection */
 
@@ -16,19 +18,57 @@
 
 namespace Tests;
 
+use Guanguans\LaravelExceptionNotify\ExceptionNotifyManager;
 use Guanguans\LaravelExceptionNotify\Tests\TestCase;
 
 uses(TestCase::class)
     ->beforeAll(function (): void {})
-    ->beforeEach(function (): void {})
+    ->beforeEach(function (): void {
+        (fn (): array => self::$skipCallbacks = [])->call(app(ExceptionNotifyManager::class));
+    })
     ->afterEach(function (): void {})
     ->afterAll(function (): void {})
     ->in(__DIR__);
 
-expect()->extend('between', function (int $min, $max) {
-    expect($this->value)
-        ->toBeGreaterThanOrEqual($min)
-        ->toBeLessThanOrEqual($max);
+/*
+|--------------------------------------------------------------------------
+| Expectations
+|--------------------------------------------------------------------------
+|
+| When you're writing tests, you often need to check that values meet certain conditions. The
+| "expect()" function gives you access to a set of "expectations" methods that you can use
+| to assert different things. Of course, you may extend the Expectation API at any time.
+|
+ */
+
+expect()->extend('toBetween', fn (int $min, int $max): Expectation => expect($this->value)
+    ->toBeGreaterThanOrEqual($min)
+    ->toBeLessThanOrEqual($max));
+
+/*
+|--------------------------------------------------------------------------
+| Functions
+|--------------------------------------------------------------------------
+|
+| While Pest is very powerful out-of-the-box, you may have some testing code specific to your
+| project that you don't want to repeat in every file. Here you can also expose helpers as
+| global functions to help you to reduce the number of lines of code in your test files.
+|
+ */
+
+/**
+ * @param object|string $class
+ *
+ * @throws ReflectionException
+ */
+function class_namespace($class): string
+{
+    $class = \is_object($class) ? \get_class($class) : $class;
+
+    return (new ReflectionClass($class))->getNamespaceName();
+}
 
-    return $this;
-});
+function fixtures_path(string $path = ''): string
+{
+    return __DIR__.\DIRECTORY_SEPARATOR.'fixtures'.($path ? \DIRECTORY_SEPARATOR.$path : $path);
+}
diff --git a/tests/Support/HeplersTest.php b/tests/Support/HeplersTest.php
index 6abdb37..f063de7 100644
--- a/tests/Support/HeplersTest.php
+++ b/tests/Support/HeplersTest.php
@@ -27,7 +27,7 @@
 
 it('can explode env', function (): void {
     expect(env_explode('ENV_EXPLODE_STRING'))->toBeArray()->toBeTruthy()
-        ->and(env_explode('ENV_EXPLODE_EMPTY'))->toBe([''])
+        ->and(env_explode('ENV_EXPLODE_EMPTY'))->toBe([])
         ->and(env_explode('ENV_EXPLODE_NOT_EXIST'))->toBeNull();
     // ->and(env_explode('ENV_EXPLODE_TRUE'))->toBeTrue()
     // ->and(env_explode('ENV_EXPLODE_FALSE'))->toBeFalse()
diff --git a/tests/TestCase.php b/tests/TestCase.php
index 330a921..66e3f26 100644
--- a/tests/TestCase.php
+++ b/tests/TestCase.php
@@ -72,6 +72,7 @@ protected function defineEnvironment($app): void
     {
         config()->set('exception-notify.job.queue', 'exception-notify');
         config()->set('exception-notify.channels.bark.authenticator.token', $this->faker()->uuid());
+        config()->set('exception-notify.channels.bark.client.http_options', []);
         config()->set('exception-notify.channels.bark.client.extender', static fn (Client $client): Client => $client->mock([
             (new HttpFactory)->createResponse(200, '{"code":200,"message":"success","timestamp":1708331409}'),
         ]));