-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS1-Extension header value format is not matching between document and openapi.yml #441
Comments
The spec is correct, the document is not
…On Thu, Jul 28, 2022 at 8:46 AM Bhavesh Shah ***@***.***> wrote:
Dear @domguinard <https://github.com/domguinard> / @mgh128
<https://github.com/mgh128>,
We observed a slight mismatch in the format of GS1-Extension header values.
*GS1-Extension header value format as mentioned in EPCIS 2.0 specification
(Section 12.3 Pg.no. 180 Section 12.7.4 Pg.no. 192-193)*:
“example-epc-ext”:”http://example.com/epcis/”
*GS1-Extension header value format in openapi.yml:* example-epc-ext=
http://org1.example.com/epcis/, example-epc-ext2=
http://vendor.example.com/epcis/
If you agree, then we should update the openapi.yml to match the format as
per specification. Let us know so that we can raise a PR.
FYI: @sboeckelmann <https://github.com/sboeckelmann>
—
Reply to this email directly, view it on GitHub
<#441>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQEZJLSDIM4J44ESXWUYRRDVWIUCTANCNFSM544CX3BA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
*IOTA Foundation*
Pappelallee 78/79
10437 Berlin, Germany
Board of
Directors: Dominik Schiener, Navin Ramachandran
ID/Foundation No.:
3416/1234/2 (Foundation Register of Berlin)
|
Thanks for flagging @dakbhavesh - I agree with @jmcanterafonseca-iota the OpenAPI spec is correct as the extensions should look like:
Do you agree @dakbhavesh ? |
Thanks @dakbhavesh , @jmcanterafonseca-iota and @domguinard; we'll also add this one to the running list of planned fixes for the next release of EPCIS. |
I agree @domguinard . |
Dear @domguinard / @mgh128,
We observed a slight mismatch in the format of GS1-Extension header values.
GS1-Extension header value format as mentioned in EPCIS 2.0 specification (Section 12.3 Pg.no. 180 Section 12.7.4 Pg.no. 192-193):
“example-epc-ext”:”http://example.com/epcis/”
GS1-Extension header value format in openapi.yml:
example-epc-ext=http://org1.example.com/epcis/, example-epc-ext2=http://vendor.example.com/epcis/
If you agree, then we should update the openapi.yml to match the format as per specification. Let us know so that we can raise a PR.
FYI: @sboeckelmann
The text was updated successfully, but these errors were encountered: