Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS1-Extension header value format is not matching between document and openapi.yml #441

Open
dakbhavesh opened this issue Jul 28, 2022 · 4 comments
Labels
errata Modifications to be applied to the next release / errata release of the standard

Comments

@dakbhavesh
Copy link
Collaborator

Dear @domguinard / @mgh128,

We observed a slight mismatch in the format of GS1-Extension header values.

GS1-Extension header value format as mentioned in EPCIS 2.0 specification (Section 12.3 Pg.no. 180 Section 12.7.4 Pg.no. 192-193): “example-epc-ext”:”http://example.com/epcis/”

GS1-Extension header value format in openapi.yml: example-epc-ext=http://org1.example.com/epcis/, example-epc-ext2=http://vendor.example.com/epcis/

If you agree, then we should update the openapi.yml to match the format as per specification. Let us know so that we can raise a PR.

FYI: @sboeckelmann

@jmcanterafonseca-iota
Copy link
Collaborator

jmcanterafonseca-iota commented Aug 1, 2022 via email

@domguinard
Copy link
Collaborator

Thanks for flagging @dakbhavesh - I agree with @jmcanterafonseca-iota the OpenAPI spec is correct as the extensions should look like:

GS1-Extensions: example-epc-ext=http://org1.example.com/epcis/, example-epc-ext2=http://vendor.example.com/epcis/ 

Do you agree @dakbhavesh ?

@domguinard domguinard added the errata Modifications to be applied to the next release / errata release of the standard label Aug 4, 2022
@CraigRe
Copy link
Collaborator

CraigRe commented Aug 4, 2022

Thanks @dakbhavesh , @jmcanterafonseca-iota and @domguinard; we'll also add this one to the running list of planned fixes for the next release of EPCIS.

@dakbhavesh
Copy link
Collaborator Author

Thanks for flagging @dakbhavesh - I agree with @jmcanterafonseca-iota the OpenAPI spec is correct as the extensions should look like:

GS1-Extensions: example-epc-ext=http://org1.example.com/epcis/, example-epc-ext2=http://vendor.example.com/epcis/ 

Do you agree @dakbhavesh ?

I agree @domguinard .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errata Modifications to be applied to the next release / errata release of the standard
Projects
None yet
Development

No branches or pull requests

4 participants