Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token lib #97

Closed
alanjds opened this issue Oct 6, 2018 · 10 comments
Closed

Add token lib #97

alanjds opened this issue Oct 6, 2018 · 10 comments
Labels
imported PR Pull Request imported from google/grumpy

Comments

@alanjds
Copy link

alanjds commented Oct 6, 2018

google#394 opened on Feb 5 by @nagayev2002

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by googlebot
Monday Feb 05, 2018 at 17:44 GMT


Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by nagayev2002
Monday Feb 05, 2018 at 17:49 GMT


@googlebot I signed it!

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by googlebot
Monday Feb 05, 2018 at 17:49 GMT


CLAs look good, thanks!

@alanjds alanjds added the imported PR Pull Request imported from google/grumpy label Oct 6, 2018
@nagayev
Copy link

nagayev commented Oct 26, 2020

ping

@alanjds
Copy link
Author

alanjds commented Oct 26, 2020

pong.

@nagayev
Copy link

nagayev commented Oct 27, 2020

Should I need create a PR for this issue?
Or is this repository dead?

@alanjds
Copy link
Author

alanjds commented Oct 27, 2020

Should I need create a PR for this issue?

If you create a PR and it passes the CI, I will review it and possibly merge.

Or is this repository dead?

Not dead, as I and others keep an eye on it, point parts of it when specific questions arrive and so on.
Would love to see it going further, however I am not personally pushing Grumpy forward this days.

When you push your PR, the CI may complain about Golang versions, for example. Once it got green, I invest time to review and merge.

@nagayev
Copy link

nagayev commented Oct 29, 2020

@alanjds OK. I will be preparing my PR for a few days.

@alanjds
Copy link
Author

alanjds commented Oct 29, 2020

Merged #155, although the PR fails on some Python 2.7->3.X issue.

Will close here, as the failure root cause is being tracked on #135.

@alanjds alanjds closed this as completed Oct 29, 2020
@alanjds
Copy link
Author

alanjds commented Oct 29, 2020

Thanks @nagayev for the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported PR Pull Request imported from google/grumpy
Projects
None yet
Development

No branches or pull requests

2 participants