From 0decfe0694ca8bf0a339fb4fcbb226102847ec83 Mon Sep 17 00:00:00 2001 From: fengli79 Date: Sun, 28 Jan 2024 07:28:31 +0000 Subject: [PATCH 1/2] Remove the `attempt` base unit for grpc_client_attempt_started metric, to make sure the generated metrics name in the Prometheus is actually grpc_client_attempt_started_total instead of grpc_client_attempt_started_attempt_total and gets aligned with other languages (C++ for example). --- .../devh/boot/grpc/client/metrics/MetricsClientInstruments.java | 1 - 1 file changed, 1 deletion(-) diff --git a/grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java b/grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java index 3967f2ccf..6b419d0b6 100644 --- a/grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java +++ b/grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java @@ -69,7 +69,6 @@ static MetricsClientMeters newClientMetricsMeters(MeterRegistry registry) { .description( "The total number of RPC attempts started from the client side, including " + "those that have not completed.") - .baseUnit("attempt") .withRegistry(registry)); builder.setSentMessageSizeDistribution(DistributionSummary.builder( From 73e190334574e8415779f9661b269e1f2dd9a53a Mon Sep 17 00:00:00 2001 From: fengli79 Date: Sun, 28 Jan 2024 08:18:00 +0000 Subject: [PATCH 2/2] Remove the `call` base unit for grpc_server_call_started metric. --- .../devh/boot/grpc/server/metrics/MetricsServerInstruments.java | 1 - 1 file changed, 1 deletion(-) diff --git a/grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/metrics/MetricsServerInstruments.java b/grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/metrics/MetricsServerInstruments.java index f5e799315..0fb4319b0 100644 --- a/grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/metrics/MetricsServerInstruments.java +++ b/grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/metrics/MetricsServerInstruments.java @@ -66,7 +66,6 @@ static MetricsServerMeters newServerMetricsMeters(MeterRegistry registry) { builder.setServerCallCounter(Counter.builder(SERVER_CALL_STARTED) .description("The total number of RPC attempts started from the server side, including " + "those that have not completed.") - .baseUnit("call") .withRegistry(registry)); builder.setSentMessageSizeDistribution(DistributionSummary.builder(