Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Re-add widget menu item #3924

Closed
mattbk opened this issue Feb 21, 2016 · 10 comments
Closed

Re-add widget menu item #3924

mattbk opened this issue Feb 21, 2016 · 10 comments

Comments

@mattbk
Copy link
Contributor

mattbk commented Feb 21, 2016

The widget menu item should be added back for Teams only, not for individual ~users.

(Change in direction at #4172).


https://gratipay.com/about/me/widgets/ was removed when widgets broke after Gratipay 2.0.

Can be done after the Widgets for Gratipay 2.0 milestone is closed.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@nobodxbodon
Copy link
Contributor

Seems working for me:
screen shot 2016-11-03 at 8 12 26 am
What's expected behavior?

@chadwhitacre
Copy link
Contributor

Hmm ... I had forgotten that this page is still there, just not listed in nav! Good find. :-)

Are you clear on the distinction between Teams and ~users, @nobodxbodon? If not, let's get you clear on it, because it matters here.

What's expected behavior?

I think we should remove the first "Button" section entirely. That really applies to Teams now, not to ~users. Same with "Badge."

I suppose we could keep the "Giving & Receiving Widgets," though now it should be "Giving & Taking" If the taking side is too broken, then we can at least document the giving side.

Thoughts, @nobodxbodon @mattbk?

@nobodxbodon
Copy link
Contributor

@whit537 Here's what I understand about the concepts, teams and users. A user can sign up any time. A team needs to be approved. A user can have multiple teams. Givers can give to teams, not individual user. If a user is owner of the team, she can distribute the income as she likes. Please correct if any is wrong.

Sounds good to your expected behavior.

BTW, I see in ~whit537 the bitcoin address, which should be removed, as Bitcoin was dropped per previous discussion?

@chadwhitacre
Copy link
Contributor

Here's what I understand about the concepts, teams and users.

👍

Sounds good to your expected behavior.

👍

bitcoin address, which should be removed

Can you reticket if we don't already have a ticket about this?

@nobodxbodon
Copy link
Contributor

@mattbk could you check if this is solved already, with my latest commit?

@mattbk
Copy link
Contributor Author

mattbk commented Nov 7, 2016

For reference: #4172

The page looks good. I think we're still half and half with the receiving vs taking terminology for ~users. Fixing that requires going back to https://github.com/gratipay/grtp.co.

The next step is to add the menu item back so people can see it.

@chadwhitacre
Copy link
Contributor

I think we're still half and half with the receiving vs taking terminology for ~users.

Say more? Are we going live with this—saying "taking"—without updating the widget to also say "taking" instead of "receiving"?

going live = linking in the nav

@mattbk
Copy link
Contributor Author

mattbk commented Nov 8, 2016

Individual widgets should say taking, team widgets should say receiving. I need to refresh my memory and get back to this.

@mattbk
Copy link
Contributor Author

mattbk commented Nov 8, 2016

going live = linking in the nav

Let's go live with this for ~user pages with the current terminology for now.

We should add a link to https://github.com/gratipay/grtp.co, because that is where team widgets are explained and code given.

Additionally, we should add a menu link for logged-in team members on team pages, and have the team widgets available there (reticketed as #4175).

@nobodxbodon, how does that sound?

@mattbk
Copy link
Contributor Author

mattbk commented Nov 12, 2016

Working on this today. Undoing #3673.

mattbk added a commit that referenced this issue Nov 12, 2016
Also add a link to widget docs. Closes #3924.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants