Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

change community page to show simple listing for < THRESHOLD #1905

Closed
chadwhitacre opened this issue Jan 16, 2014 · 6 comments
Closed

change community page to show simple listing for < THRESHOLD #1905

chadwhitacre opened this issue Jan 16, 2014 · 6 comments

Comments

@chadwhitacre
Copy link
Contributor

Reticketing from #1316. We basically want just the "Newest Participants" listing, but not titled as such and maybe a simpler presentation.

@seanlinsley
Copy link
Contributor

I'm pretty sure we've agreed that below the current three columns, there'd be a a full-width area for all users, with a button to load the next bunch of them. It seems like that would exist no matter the number of people in the community, so perhaps for small communities we could update the current "new members" column so it's a full-width section, but only one row tall. Something like:

screen shot 2014-01-15 at 11 04 26 pm

@chadwhitacre
Copy link
Contributor Author

I'm pretty sure we've agreed that below the current three columns, there'd be a a full-width area for all users, with a button to load the next bunch of them.

I don't remember agreeing to that. :-(

My understanding was that the "more" button on #970 would effectively turn the existing three-column layout into a listing of all users. No?

We also have to think about what this page will do on mobile.

@chadwhitacre
Copy link
Contributor Author

I think we should implement this by only showing the "New Participants" listing below NMEMBERS_THRESHOLD. That is simple and effective and is a small change to make.

@chadwhitacre
Copy link
Contributor Author

(The challenge of the "more" button on mobile properly belongs to #970.)

chadwhitacre added a commit that referenced this issue Jan 16, 2014
This renames the "New Members" listing to "All Members" and shows this
listing on all community pages. The "Top Givers" and "Top Receivers"
listings are still only show for communities with more than
NMEMBERS_THRESHOLD members.
@chadwhitacre
Copy link
Contributor Author

Addressed in #1910.

chadwhitacre added a commit that referenced this issue Jan 16, 2014
This renames the "New Members" listing to "All Members" and shows this
listing on all community pages. The "Top Givers" and "Top Receivers"
listings are still only show for communities with more than
NMEMBERS_THRESHOLD members.
chadwhitacre added a commit that referenced this issue Jan 16, 2014
This renames the "New Members" listing to "All Members" and shows this
listing on all community pages. The "Top Givers" and "Top Receivers"
listings are still only show for communities with more than
NMEMBERS_THRESHOLD members.
@chadwhitacre
Copy link
Contributor Author

I just dropped NMEMBERS_THRESHOLD to 0. I realized that #963 actually helps us here, in that it lessens the chance of inferring who gives to whom. Any viable community should fairly rapidly surpass the stage where inference is a problem. And it's not a huge problem, anyway, because it does take a little work and we're not super hardline about this (we expect people to tell other people on Twitter when they're giving to them, e.g.).

chadwhitacre added a commit that referenced this issue Jan 17, 2014
We're not using it anymore. See #1905.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants