From e4cb41276760d116ce12c06019142d229a66dc0a Mon Sep 17 00:00:00 2001 From: Ransom Williams Date: Sun, 16 Jul 2023 12:55:36 -0500 Subject: [PATCH 1/2] test [1293]: regression test print schema with InputObjectType with DateTime field with default_value --- graphene/tests/issues/test_1293.py | 41 ++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 graphene/tests/issues/test_1293.py diff --git a/graphene/tests/issues/test_1293.py b/graphene/tests/issues/test_1293.py new file mode 100644 index 00000000..a3354ca5 --- /dev/null +++ b/graphene/tests/issues/test_1293.py @@ -0,0 +1,41 @@ +# https://github.com/graphql-python/graphene/issues/1293 + +import datetime + +import graphene +from graphql.utilities import print_schema + + +class Filters(graphene.InputObjectType): + datetime_after = graphene.DateTime( + required=False, + default_value=datetime.datetime.utcfromtimestamp(1434549820776 / 1000), + ) + datetime_before = graphene.DateTime( + required=False, + default_value=datetime.datetime.utcfromtimestamp(1444549820776 / 1000), + ) + + +class SetDatetime(graphene.Mutation): + class Arguments: + filters = Filters(required=True) + + ok = graphene.Boolean() + + def mutate(root, info, filters): + return SetDatetime(ok=True) + + +class Query(graphene.ObjectType): + goodbye = graphene.String() + + +class Mutations(graphene.ObjectType): + set_datetime = SetDatetime.Field() + + +def test_print_schema(): + schema = graphene.Schema(query=Query, mutation=Mutations) + schema_str = print_schema(schema.graphql_schema) + assert schema_str, "non-empty schema printed" From 29eaea4c6bc3bff79d41a145795f9fcb7c653668 Mon Sep 17 00:00:00 2001 From: Erik Wrede Date: Wed, 19 Jul 2023 08:59:24 +0200 Subject: [PATCH 2/2] chore: clarify test title and assertion --- graphene/tests/issues/test_1293.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/graphene/tests/issues/test_1293.py b/graphene/tests/issues/test_1293.py index a3354ca5..20bcde95 100644 --- a/graphene/tests/issues/test_1293.py +++ b/graphene/tests/issues/test_1293.py @@ -35,7 +35,7 @@ class Mutations(graphene.ObjectType): set_datetime = SetDatetime.Field() -def test_print_schema(): +def test_schema_printable_with_default_datetime_value(): schema = graphene.Schema(query=Query, mutation=Mutations) schema_str = print_schema(schema.graphql_schema) - assert schema_str, "non-empty schema printed" + assert schema_str, "empty schema printed"