Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very Very different PSNR between the original and the latest version #1048

Open
731875679 opened this issue Nov 5, 2024 · 3 comments
Open

Comments

@731875679
Copy link

I have followed this program since Aug, 2023. (Many thanks to the relevant workers!) Recently, I noticed the program updated a lot. Therefore, I also updated the codes in my computer. However, when I trained the same directory, which is created by running COLMAP with a series of figures, I got a really very different PSNR after same times of training. With the original version, only use the loss function like belows,

Ll1 = l1_loss(image, gt_image)
loss = (1.0 - opt.lambda_dssim) * Ll1 + opt.lambda_dssim * (1.0 - ssim(image, gt_image))

the PSNR is aroud 20 or 30. However, with the latest version, loss funtion like,

Ll1 = l1_loss(image, gt_image)
if FUSED_SSIM_AVAILABLE:
ssim_value = fused_ssim(image.unsqueeze(0), gt_image.unsqueeze(0))
else:
ssim_value = ssim(image, gt_image)

loss = (1.0 - opt.lambda_dssim) * Ll1 + opt.lambda_dssim * (1.0 - ssim_value)

I got PSNR is aroud 7 or 8, less a lot. I have examined they have both the same training_report function, which print the PSNR. However, observed with my naked eyes that the difference between the figures was very tiny. High distance in PSNR number, low in figures. I want to know WHY?

Really appreciate!!!

@AsherJingkongChen
Copy link

AsherJingkongChen commented Nov 6, 2024

Please update your submodules by git submodule update --init --recursive --remote

See #1050

@731875679
Copy link
Author

Please update your submodules by git submodule update --init --recursive --remote

See #1050

THANKS A LOT! I will try.

@731875679
Copy link
Author

Please update your submodules by git submodule update --init --recursive --remote

See #1050

everything gonna be fine!!! you are right!!! really appreciate!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants