Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic clamp #1046

Open
kevintsq opened this issue Nov 3, 2024 · 1 comment
Open

Problematic clamp #1046

kevintsq opened this issue Nov 3, 2024 · 1 comment

Comments

@kevintsq
Copy link

kevintsq commented Nov 3, 2024

rendered_image = rendered_image.clamp(0, 1)

When the GS module is attached to other modules, this clamp can cause the system to fail to learn.

p.s. There are also unnecessary clamps in the code that may affect performance.

@AsherJingkongChen
Copy link

AsherJingkongChen commented Nov 3, 2024

The comment is clear: "They will be excluded from value updates." That's why they clamp the image. Nothing should be learned from those invisible pixels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants