Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minor question #1045

Open
M11pha opened this issue Nov 2, 2024 · 2 comments
Open

A minor question #1045

M11pha opened this issue Nov 2, 2024 · 2 comments

Comments

@M11pha
Copy link

M11pha commented Nov 2, 2024

Hello, on the line 155 of gaussian_model.py, should features[:, 3:, 1:] = 0.0 be features[:, :3, 1:] = 0.0 instead?

def create_from_pcd(self, pcd : BasicPointCloud, cam_infos : int, spatial_lr_scale : float):
        self.spatial_lr_scale = spatial_lr_scale
        fused_point_cloud = torch.tensor(np.asarray(pcd.points)).float().cuda()
        fused_color = RGB2SH(torch.tensor(np.asarray(pcd.colors)).float().cuda())
        features = torch.zeros((fused_color.shape[0], 3, (self.max_sh_degree + 1) ** 2)).float().cuda()
        features[:, :3, 0 ] = fused_color
        features[:, 3:, 1:] = 0.0
@AsherJingkongChen
Copy link

AsherJingkongChen commented Nov 3, 2024

The line is even redundant.

@M11pha
Copy link
Author

M11pha commented Nov 5, 2024

The line is even redundant.

Yes, I think it was originally written this way to deliberately emphasize the point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants