Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions for custom filters #310

Open
DavidMStraub opened this issue Aug 31, 2022 · 0 comments · May be fixed by #513
Open

Permissions for custom filters #310

DavidMStraub opened this issue Aug 31, 2022 · 0 comments · May be fixed by #513
Assignees

Comments

@DavidMStraub
Copy link
Member

Currently, name groups and filters (/api/name_groups, /api/filters) can be edited (put, post, delete) by any logged-in users, without special edit permissions. I think this needs to change, the question is whether we use the same permissions as for primary objects, i.e. Contributors can add, Editors can edit and delete, or different ones. Custom filters are a special case as they are not specific to a tree but shared for an entire Gramps installation, stored in an XML in the config directory rather than the family tree database.

DavidMStraub added a commit to DavidMStraub/gramps-webapi that referenced this issue Mar 10, 2023
@DavidMStraub DavidMStraub self-assigned this Mar 11, 2023
DavidMStraub added a commit that referenced this issue Mar 15, 2023
* Require elevated permissions to edit name groups (#310)

* Update apispec
@DavidMStraub DavidMStraub changed the title Permissions for name groups and filters Permissions for custom filters Mar 15, 2023
@DavidMStraub DavidMStraub linked a pull request Apr 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant