Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 2.4.x breaks maven-based plugin builds #43

Open
ryangardner opened this issue Jun 6, 2014 · 0 comments
Open

Grails 2.4.x breaks maven-based plugin builds #43

ryangardner opened this issue Jun 6, 2014 · 0 comments

Comments

@ryangardner
Copy link
Contributor

https://github.com/grails/grails-maven/blob/master/src/main/java/org/grails/maven/plugin/tools/DefaultGrailsServices.java#L141

The plugin is now calling out to a method called getClassNameForLowerCaseHyphenSeparatedName - that method is designed to take a class that is named like "foo-bar-baz" and turn it into "FooBarBaz".

The problem is that this is precisely the opposite of what used to happen at this line. It used to call out to GrailsNameUtils.getScriptName(GrailsNameUtils.getLogicalName(className, "GrailsPlugin"));

that method takes strings like "FooBarBaz" and turn it into "foo-bar-baz"

The net result of this change is that it wont pass the validator and gives strange errors to us as we try to run it.

Should I just copy the code that used to do the getScriptName method into this mojo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant