Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/log examples fail #28

Open
jcharum opened this issue Jan 8, 2021 · 1 comment
Open

common/log examples fail #28

jcharum opened this issue Jan 8, 2021 · 1 comment

Comments

@jcharum
Copy link
Contributor

jcharum commented Jan 8, 2021

See failures here: https://travis-ci.org/github/grailbio/base/jobs/753609179#L486-L604 .

The example output is sensitive to source file location. These need to be made more robust.
@jcharum
Copy link
Contributor Author

jcharum commented Jan 8, 2021

Reproduce by running:

go test github.com/grailbio/base/common/log

jcharum pushed a commit that referenced this issue Jan 26, 2021
@jcharum
log: caller field should only be file name and line
bcc3a55 
Summary:
Change the automatically logged `caller` field from full file path to only file name.

The impetus for this change is that the caller root will be different depending on the system. For example, the tests will pass with `bazel test`, but fail with `go test`. We could possibly configure the full file path to be an option in the future.

Github Issue: #28

Test Plan: Update unit tests.

Reviewers: fdegiuli, msabherwal

Reviewed By: fdegiuli

Subscribers: jcharumilind, smahadevan

Differential Revision: https://phabricator.grailbio.com/D53636

fbshipit-source-id: 0a74d6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcharum