Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace json with serde_json #180

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Oct 13, 2024

Fixes #139 and includes a slight refactor to make this code more Rusty.

Not tested manually, had only ran unit tests.

```
error[E0282]: type annotations needed for `Box<_>`
  --> /home/mateusz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`
```
@mati865 mati865 requested review from a team as code owners October 13, 2024 21:19
@korniltsev korniltsev changed the title fix: update time crate to fix build error with new Rust fix: replace json with serde_json Oct 14, 2024
@korniltsev korniltsev merged commit face91b into grafana:main Oct 14, 2024
3 of 11 checks passed
@mati865 mati865 deleted the get-rid-of-json branch October 14, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using JSON internally
2 participants