Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix documentation for helm extraPorts #1998

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix documentation for helm extraPorts #1998

wants to merge 8 commits into from

Conversation

jkruke
Copy link

@jkruke jkruke commented Oct 29, 2024

PR Description

Which issue(s) this PR fixes

Fixes #1997

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

@jkruke jkruke requested a review from a team as a code owner October 29, 2024 17:23
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@clayton-cornell
Copy link
Contributor

clayton-cornell commented Oct 29, 2024 •
edited
Loading

@jkruke Don't forget to sign the CLA so we can move forward with your PR.

The Helm chart tests are not up to date. Please run make generate-helm-tests and commit changes!

@jkruke
Copy link
Author

jkruke commented Oct 30, 2024

@clayton-cornell The CLA is now signed and I ran the helm tests.
Due to the results, I realized that k8s pod ports need hostPort, but a service needs port.
So I changed the service templates to use hostPort instead of the (not documented) port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs feedback: Helm chart alloy.extraPorts.hostPort should be port instead
3 participants
@jkruke @CLAassistant @clayton-cornell