You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice PR ! It looks good to me 🚀. I just have a question: do you think it could be interesting to have a StatusChip component who have the same props as the others, but with a colour and an icon in addition ? This could allows to reuse this component inside Required, Saved and SubmittedChip component and reducing the little code duplication. Maybe it is not what we want, it is just a question 😉.
@ReidyT@swouf I agree, we could have a single component that exposes a variant prop that could take the required | submitted | saved values and then simply switch on them in the component. The structure could be the same and you only have to switch on the color and icon properties. You can put them in a dictionary that indexes over the custom chip variant.
But as Thibault has said, do this only if re-use is important.
Posted by @ReidyT
But as Thibault has said, do this only if re-use is important.
Originally posted by @spaenleh in #872 (review)
The text was updated successfully, but these errors were encountered: