Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix white-space and indentation inconsistencies in ... #1002

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

axxel
Copy link
Contributor

@axxel axxel commented Sep 4, 2024

  • examples
  • gphoto2
  • libgphoto2
  • libgphoto2_port

The code (at least in this part of the project) is effectively formated using tabs with a tab-size of 8 as a means for indentation.

There have been a few places where spaces were introduced. Some obviously with an indent size of 8 in mind, others with an indent size of 4.

This commit tries its best to make the use of tabs consistent again, at least for indenting lines. The "intra line" indentation (white space after the first non-white-space character) is still a bit of a mess.

 * examples
 * gphoto2
 * libgphoto2
 * libgphoto2_port

The code (at least in this part of the project) is effectively formated
using tabs with a tab-size of 8 as a means for indentation.

There have been a few places where spaces were introduced. Some obviously
with an indent size of 8 in mind, others with an indent size of 4.

This commit tries its best to make the use of tabs consistent again, at
least for indenting lines. The "intra line" indentation (white space after
the first non-white-space character) is still a bit of a mess.
@msmeissn msmeissn merged commit 5c9d7b2 into gphoto:master Sep 5, 2024
4 of 5 checks passed
@msmeissn
Copy link
Contributor

msmeissn commented Sep 5, 2024

thanks!

@axxel axxel deleted the ws-cleanup-2 branch September 5, 2024 08:15
axxel added a commit to axxel/libgphoto2 that referenced this pull request Sep 14, 2024
This is basically a continuation of the work from gphoto#1002 but her for the
camlibs directory. The purpose was to replace spaces as a means for
indentation with tab characters.

Note: there are some files which are still offending the general
rule but are (mostly) consistent within themselves. I let them be for
the moment. Fixing them would basically replace the whole file.

Also: there are still a ton of whitespace related inconsistencies like
"x=10" vs "x = 10" or "func(10)" vs "func (10)".

This is a whitespace only change (if you include newlines as whitespace).
msmeissn pushed a commit that referenced this pull request Sep 15, 2024
This is basically a continuation of the work from #1002 but her for the
camlibs directory. The purpose was to replace spaces as a means for
indentation with tab characters.

Note: there are some files which are still offending the general
rule but are (mostly) consistent within themselves. I let them be for
the moment. Fixing them would basically replace the whole file.

Also: there are still a ton of whitespace related inconsistencies like
"x=10" vs "x = 10" or "func(10)" vs "func (10)".

This is a whitespace only change (if you include newlines as whitespace).
axxel added a commit to axxel/libgphoto2 that referenced this pull request Sep 15, 2024
axxel added a commit to axxel/libgphoto2 that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants