From efde1fce5a548bddac675c7563883ff8b2695fe3 Mon Sep 17 00:00:00 2001 From: Sandra Soinska Date: Fri, 30 Aug 2024 09:27:59 +0100 Subject: [PATCH 01/15] OJ-2748 one request set in nino-check script to warm lambda --- deploy/scripts/src/common/imposter.ts | 25 +++++++++++++++++++++ deploy/scripts/src/cri-orange/nino-check.ts | 12 +++++++++- 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 deploy/scripts/src/common/imposter.ts diff --git a/deploy/scripts/src/common/imposter.ts b/deploy/scripts/src/common/imposter.ts new file mode 100644 index 00000000..cbf3366a --- /dev/null +++ b/deploy/scripts/src/common/imposter.ts @@ -0,0 +1,25 @@ +import http from 'k6/http'; + +export class Imposter { + public handler() { + const url = 'https://26okyhxy99.execute-api.eu-west-2.amazonaws.com/build/individuals/authentication/authenticator/api/match'; + + const body = JSON.stringify({ + firstName: 'Jim', + lastName: 'Ferguson', + dateOfBirth: '1970-01-01', + nino: 'AA000003D', + }); + + const params = { + headers: { + 'Content-Type': 'application/json', + Authorization: 'Bearer goodToken', + }, + }; + + const response = http.post(url, body, params); + + return response; + } +} \ No newline at end of file diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index 6436e03c..87265c00 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -15,6 +15,9 @@ import { isStatusCode200, isStatusCode302, pageContentCheck } from '../common/ut import { sleepBetween } from '../common/utils/sleep/sleepBetween' import { getEnv } from '../common/utils/config/environment-variables' import { getThresholds } from '../common/utils/config/thresholds' +import { Imposter } from '../common/imposter' + +const imposter = new Imposter() const profiles: ProfileList = { smoke: { @@ -83,7 +86,14 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { }) }) -export function ninoCheck(): void { +let imposterstarted = false + +export function ninoCheck(): void{ + if (!imposterstarted) { const response = imposter.handler(); + console.log('Response status: ', response.status); + console.log('Response body: ', response.body); + imposterstarted = true + } const groups = groupMap.ninoCheck let res: Response const credentials = `${stubCreds.userName}:${stubCreds.password}` From 673974ab988cd91918f170a47470423e01246fc1 Mon Sep 17 00:00:00 2001 From: Sandra Soinska Date: Mon, 2 Sep 2024 16:22:44 +0100 Subject: [PATCH 02/15] OJ-2748 one request set in nino-check script to warm lambda --- deploy/scripts/src/common/imposter.ts | 22 +++++++++++++++++++++ deploy/scripts/src/cri-orange/nino-check.ts | 12 ++++++++++- 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 deploy/scripts/src/common/imposter.ts diff --git a/deploy/scripts/src/common/imposter.ts b/deploy/scripts/src/common/imposter.ts new file mode 100644 index 00000000..5c8190ea --- /dev/null +++ b/deploy/scripts/src/common/imposter.ts @@ -0,0 +1,22 @@ +import http from 'k6/http'; + +export class Imposter { + public handler() { + const url = 'https://privatevpceid'; + + const body = JSON.stringify({ + 'jsonbody' + }); + + const params = { + headers: { + 'Content-Type': 'application/json', + Authorization: 'Bearer goodToken', + }, + }; + + const response = http.post(url, body, params); + + return response; + } +} \ No newline at end of file diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index 6436e03c..902a86ca 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -15,6 +15,9 @@ import { isStatusCode200, isStatusCode302, pageContentCheck } from '../common/ut import { sleepBetween } from '../common/utils/sleep/sleepBetween' import { getEnv } from '../common/utils/config/environment-variables' import { getThresholds } from '../common/utils/config/thresholds' +import { Imposter } from '../common/imposter' + +const imposter = new Imposter() const profiles: ProfileList = { smoke: { @@ -83,7 +86,14 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { }) }) -export function ninoCheck(): void { +let imposterstarted = false + +export function ninoCheck(): void{ + if (!imposterstarted) { const response = imposter.handler(); + console.log('Response status: ', response.status); + console.log('Response body: ', response.body); + imposterstarted = true + } const groups = groupMap.ninoCheck let res: Response const credentials = `${stubCreds.userName}:${stubCreds.password}` From 060c482366cfacfa56491ffaeb4421ef78d7a371 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Thu, 5 Sep 2024 17:31:55 +0100 Subject: [PATCH 03/15] Fixed linting issues --- deploy/scripts/src/cri-orange/nino-check.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index 87265c00..4124ad78 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -88,10 +88,11 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { let imposterstarted = false -export function ninoCheck(): void{ - if (!imposterstarted) { const response = imposter.handler(); - console.log('Response status: ', response.status); - console.log('Response body: ', response.body); +export function ninoCheck(): void { + if (!imposterstarted) { + const response = imposter.handler() + console.log('Response status: ', response.status) + console.log('Response body: ', response.body) imposterstarted = true } const groups = groupMap.ninoCheck From 9b0e19cc6076486e3a98d28c852650cca29671bb Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Fri, 6 Sep 2024 13:05:23 +0100 Subject: [PATCH 04/15] Fix Linting issues after merge from main --- deploy/scripts/src/cri-orange/nino-check.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index e77ff5c4..4124ad78 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -88,12 +88,11 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { let imposterstarted = false -let imposterstarted = false - -export function ninoCheck(): void{ - if (!imposterstarted) { const response = imposter.handler(); - console.log('Response status: ', response.status); - console.log('Response body: ', response.body); +export function ninoCheck(): void { + if (!imposterstarted) { + const response = imposter.handler() + console.log('Response status: ', response.status) + console.log('Response body: ', response.body) imposterstarted = true } const groups = groupMap.ninoCheck From c6002bf48eb87fcb844e5122d4145983bc8132a3 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Fri, 6 Sep 2024 13:12:26 +0100 Subject: [PATCH 05/15] Parameterize imposter stub URL and payload --- deploy/scripts/src/common/imposter.ts | 28 ++++++++++++++++----------- deploy/template.yaml | 2 ++ 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/deploy/scripts/src/common/imposter.ts b/deploy/scripts/src/common/imposter.ts index 5c8190ea..5b0f0d17 100644 --- a/deploy/scripts/src/common/imposter.ts +++ b/deploy/scripts/src/common/imposter.ts @@ -1,22 +1,28 @@ -import http from 'k6/http'; +import http from 'k6/http' +import { getEnv } from './utils/config/environment-variables' + +const env = { + imposterStubURL: getEnv('IDENTITY_NINO_IMPOSTER_STUB_URL') +} +const payload = { + reqBody: getEnv('IDENTITY_NINO_IMPOSTER_PAYLOAD') +} export class Imposter { public handler() { - const url = 'https://privatevpceid'; + const url = `'https://${env.imposterStubURL}` - const body = JSON.stringify({ - 'jsonbody' - }); + const body = JSON.stringify(payload.reqBody) const params = { headers: { 'Content-Type': 'application/json', - Authorization: 'Bearer goodToken', - }, - }; + Authorization: 'Bearer goodToken' + } + } - const response = http.post(url, body, params); + const response = http.post(url, body, params) - return response; + return response } -} \ No newline at end of file +} diff --git a/deploy/template.yaml b/deploy/template.yaml index fb597f10..2c1fae86 100644 --- a/deploy/template.yaml +++ b/deploy/template.yaml @@ -478,6 +478,8 @@ Resources: IDENTITY_KIWI_F2F_STUB_URL: "/perfTest/identity/kiwi/f2f/stubUrl" IDENTITY_KIWI_F2F_TARGET: "/perfTest/identity/kiwi/f2f/target" IDENTITY_KIWI_STUB_SQS: "/perfTest/identity/kiwi/stubTxMAConsumer" + IDENTITY_NINO_IMPOSTER_STUB_URL: "/perfTest/identity/nino/imposterStubUrl" + IDENTITY_NINO_IMPOSTER_PAYLOAD: "/perfTest/identity/nino/imposterStubPayload" IDENTITY_ORCH_STUB_PASSWORD: "/perfTest/identity/orchStubPassword" IDENTITY_ORCH_STUB_USERNAME: "/perfTest/identity/orchStubUsername" IDENTITY_PASSPORT_URL: "/perfTest/identity/lime/passportUrl" From c9b724f6d5ec21e4d793db720e2695bd26651716 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Fri, 6 Sep 2024 15:37:37 +0100 Subject: [PATCH 06/15] Update Imposter Stub URL path --- deploy/scripts/src/common/imposter.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/scripts/src/common/imposter.ts b/deploy/scripts/src/common/imposter.ts index 5b0f0d17..8d32ab4f 100644 --- a/deploy/scripts/src/common/imposter.ts +++ b/deploy/scripts/src/common/imposter.ts @@ -10,7 +10,7 @@ const payload = { export class Imposter { public handler() { - const url = `'https://${env.imposterStubURL}` + const url = `https://${env.imposterStubURL}/build/individuals/authentication/authenticator/api/match` const body = JSON.stringify(payload.reqBody) From cee80103008b9d9e812483cd56ec63ca8d53aeeb Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Fri, 6 Sep 2024 15:40:55 +0100 Subject: [PATCH 07/15] Move the imposter call in set up stage --- deploy/scripts/src/cri-orange/nino-check.ts | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index 4124ad78..578dd9bf 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -46,10 +46,6 @@ export const options: Options = { tags: { name: '' } } -export function setup(): void { - describeProfile(loadProfile) -} - const env = { ipvCoreStub: getEnv('IDENTITY_CORE_STUB_URL'), envName: getEnv('ENVIRONMENT') @@ -86,15 +82,18 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { }) }) -let imposterstarted = false - -export function ninoCheck(): void { +export function setup(): void { + describeProfile(loadProfile) + let imposterstarted = false if (!imposterstarted) { const response = imposter.handler() console.log('Response status: ', response.status) console.log('Response body: ', response.body) imposterstarted = true } +} + +export function ninoCheck(): void { const groups = groupMap.ninoCheck let res: Response const credentials = `${stubCreds.userName}:${stubCreds.password}` From 8a53d4be5023dc44c8d3b545b8de716bf4a2ee29 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Tue, 10 Sep 2024 15:09:51 +0100 Subject: [PATCH 08/15] Parameterizing bearer token --- deploy/scripts/src/common/imposter.ts | 3 ++- deploy/template.yaml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/deploy/scripts/src/common/imposter.ts b/deploy/scripts/src/common/imposter.ts index 8d32ab4f..8f86a744 100644 --- a/deploy/scripts/src/common/imposter.ts +++ b/deploy/scripts/src/common/imposter.ts @@ -7,6 +7,7 @@ const env = { const payload = { reqBody: getEnv('IDENTITY_NINO_IMPOSTER_PAYLOAD') } +const bearerToken = getEnv('IDENTITY_NINO_BEARER_TOKEN') export class Imposter { public handler() { @@ -17,7 +18,7 @@ export class Imposter { const params = { headers: { 'Content-Type': 'application/json', - Authorization: 'Bearer goodToken' + Authorization: bearerToken } } diff --git a/deploy/template.yaml b/deploy/template.yaml index 2c1fae86..0accddba 100644 --- a/deploy/template.yaml +++ b/deploy/template.yaml @@ -478,6 +478,7 @@ Resources: IDENTITY_KIWI_F2F_STUB_URL: "/perfTest/identity/kiwi/f2f/stubUrl" IDENTITY_KIWI_F2F_TARGET: "/perfTest/identity/kiwi/f2f/target" IDENTITY_KIWI_STUB_SQS: "/perfTest/identity/kiwi/stubTxMAConsumer" + IDENTITY_NINO_BEARER_TOKEN: "/perfTest/identity/nino/bearerToken" IDENTITY_NINO_IMPOSTER_STUB_URL: "/perfTest/identity/nino/imposterStubUrl" IDENTITY_NINO_IMPOSTER_PAYLOAD: "/perfTest/identity/nino/imposterStubPayload" IDENTITY_ORCH_STUB_PASSWORD: "/perfTest/identity/orchStubPassword" From 1092c20d169f4d44282ca39919869f91b60f5244 Mon Sep 17 00:00:00 2001 From: Sandra Soinska Date: Wed, 11 Sep 2024 11:10:01 +0100 Subject: [PATCH 09/15] Function name and Readme updated --- deploy/scripts/README.md | 2 ++ deploy/scripts/src/common/{imposter.ts => lambda-warmer.ts} | 0 deploy/scripts/src/cri-orange/nino-check.ts | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) rename deploy/scripts/src/common/{imposter.ts => lambda-warmer.ts} (100%) diff --git a/deploy/scripts/README.md b/deploy/scripts/README.md index fe925c24..097820f1 100644 --- a/deploy/scripts/README.md +++ b/deploy/scripts/README.md @@ -103,6 +103,8 @@ Parameter store locations must start with the prefix `/perfTest/` in order for t |`SCENARIO`|`all`[_default_]
`sign_in`
`create_account,sign_in`|Comma seperated list of scenarios to enable. Blank strings or `'all'` will default to enabling all scenarios in the selected load profile. Implementation in [`getScenarios`](src/common/utils/config/load-profiles.ts#L27-L36) function| |`ENVIRONMENT`|`build`[_default_]
`staging`|Name of the environment where the test is being conducted. Accepted Values are build/staging depending on the test scenario| +Note: To overcome latency issues caused by lambda cold starts, a [lambda warmer script](src/common/lambda-warmer.ts) is ran before performance tests. This sends concurrent requests to the respective imposter stub. + 5. Click 'Start Build' 6. Build progress and the stdout results summary are printed in the 'Build logs' diff --git a/deploy/scripts/src/common/imposter.ts b/deploy/scripts/src/common/lambda-warmer.ts similarity index 100% rename from deploy/scripts/src/common/imposter.ts rename to deploy/scripts/src/common/lambda-warmer.ts diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index 578dd9bf..68f93346 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -15,7 +15,7 @@ import { isStatusCode200, isStatusCode302, pageContentCheck } from '../common/ut import { sleepBetween } from '../common/utils/sleep/sleepBetween' import { getEnv } from '../common/utils/config/environment-variables' import { getThresholds } from '../common/utils/config/thresholds' -import { Imposter } from '../common/imposter' +import { Imposter } from '../common/lambda-warmer' const imposter = new Imposter() From f3798d60188c7e8e638168464e533c9ecafcd282 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Wed, 11 Sep 2024 16:19:08 +0100 Subject: [PATCH 10/15] Updated env var names and parameterize env name in URL --- deploy/scripts/src/common/imposter.ts | 9 +++++---- deploy/template.yaml | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/deploy/scripts/src/common/imposter.ts b/deploy/scripts/src/common/imposter.ts index 8f86a744..073a950d 100644 --- a/deploy/scripts/src/common/imposter.ts +++ b/deploy/scripts/src/common/imposter.ts @@ -2,16 +2,17 @@ import http from 'k6/http' import { getEnv } from './utils/config/environment-variables' const env = { - imposterStubURL: getEnv('IDENTITY_NINO_IMPOSTER_STUB_URL') + imposterStubURL: getEnv('IDENTITY_IMPOSTER_STUB_URL'), + environment: getEnv('ENVIRONMENT') } const payload = { - reqBody: getEnv('IDENTITY_NINO_IMPOSTER_PAYLOAD') + reqBody: getEnv('IDENTITY_IMPOSTER_PAYLOAD') } -const bearerToken = getEnv('IDENTITY_NINO_BEARER_TOKEN') +const bearerToken = getEnv('IDENTITY_IMPOSTER_BEARER_TOKEN') export class Imposter { public handler() { - const url = `https://${env.imposterStubURL}/build/individuals/authentication/authenticator/api/match` + const url = `https://${env.imposterStubURL}/${env.environment}/individuals/authentication/authenticator/api/match` const body = JSON.stringify(payload.reqBody) diff --git a/deploy/template.yaml b/deploy/template.yaml index 0accddba..119aae2b 100644 --- a/deploy/template.yaml +++ b/deploy/template.yaml @@ -478,9 +478,9 @@ Resources: IDENTITY_KIWI_F2F_STUB_URL: "/perfTest/identity/kiwi/f2f/stubUrl" IDENTITY_KIWI_F2F_TARGET: "/perfTest/identity/kiwi/f2f/target" IDENTITY_KIWI_STUB_SQS: "/perfTest/identity/kiwi/stubTxMAConsumer" - IDENTITY_NINO_BEARER_TOKEN: "/perfTest/identity/nino/bearerToken" - IDENTITY_NINO_IMPOSTER_STUB_URL: "/perfTest/identity/nino/imposterStubUrl" - IDENTITY_NINO_IMPOSTER_PAYLOAD: "/perfTest/identity/nino/imposterStubPayload" + IDENTITY_IMPOSTER_BEARER_TOKEN: "/perfTest/identity/nino/bearerToken" + IDENTITY_IMPOSTER_PAYLOAD: "/perfTest/identity/nino/imposterStubPayload" + IDENTITY_IMPOSTER_STUB_URL: "/perfTest/identity/nino/imposterStubUrl" IDENTITY_ORCH_STUB_PASSWORD: "/perfTest/identity/orchStubPassword" IDENTITY_ORCH_STUB_USERNAME: "/perfTest/identity/orchStubUsername" IDENTITY_PASSPORT_URL: "/perfTest/identity/lime/passportUrl" From 2264d257f3f8ae445c216f78d136aebf69bbe577 Mon Sep 17 00:00:00 2001 From: Sandra Soinska Date: Wed, 18 Sep 2024 09:04:01 +0100 Subject: [PATCH 11/15] Move imposter call in default stage --- deploy/scripts/src/cri-orange/nino-check.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index 68f93346..f9a06ba1 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -84,6 +84,9 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { export function setup(): void { describeProfile(loadProfile) +} + +export function ninoCheck(): void { let imposterstarted = false if (!imposterstarted) { const response = imposter.handler() @@ -91,9 +94,6 @@ export function setup(): void { console.log('Response body: ', response.body) imposterstarted = true } -} - -export function ninoCheck(): void { const groups = groupMap.ninoCheck let res: Response const credentials = `${stubCreds.userName}:${stubCreds.password}` From c969a9c6061218d7c215fb4b37dd969761180dcd Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Thu, 3 Oct 2024 16:49:23 +0100 Subject: [PATCH 12/15] Move imposter stub to set up function and make concurrent batch request --- deploy/scripts/src/common/lambda-warmer.ts | 20 +++++++++++--------- deploy/scripts/src/cri-orange/nino-check.ts | 13 +++++++------ 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/deploy/scripts/src/common/lambda-warmer.ts b/deploy/scripts/src/common/lambda-warmer.ts index 073a950d..e7102ffe 100644 --- a/deploy/scripts/src/common/lambda-warmer.ts +++ b/deploy/scripts/src/common/lambda-warmer.ts @@ -12,18 +12,20 @@ const bearerToken = getEnv('IDENTITY_IMPOSTER_BEARER_TOKEN') export class Imposter { public handler() { - const url = `https://${env.imposterStubURL}/${env.environment}/individuals/authentication/authenticator/api/match` - - const body = JSON.stringify(payload.reqBody) - - const params = { - headers: { - 'Content-Type': 'application/json', - Authorization: bearerToken + const req = { + method: 'POST', + url: `https://${env.imposterStubURL}/${env.environment}/individuals/authentication/authenticator/api/match`, + body: JSON.stringify(payload.reqBody), + params: { + headers: { + 'Content-Type': 'application/json', + Authorization: bearerToken + } } } - const response = http.post(url, body, params) + const reqArray = Array(10).fill(req) + const response = http.batch(reqArray) return response } diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index f9a06ba1..e0d33f94 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -43,7 +43,8 @@ const groupMap = { export const options: Options = { scenarios: loadProfile.scenarios, thresholds: getThresholds(groupMap), - tags: { name: '' } + tags: { name: '' }, + batchPerHost: 10 } const env = { @@ -84,16 +85,16 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { export function setup(): void { describeProfile(loadProfile) -} - -export function ninoCheck(): void { let imposterstarted = false if (!imposterstarted) { const response = imposter.handler() - console.log('Response status: ', response.status) - console.log('Response body: ', response.body) + console.log('Response status: ', response[0].status) + console.log('Response body: ', response[0].body) imposterstarted = true } +} + +export function ninoCheck(): void { const groups = groupMap.ninoCheck let res: Response const credentials = `${stubCreds.userName}:${stubCreds.password}` From d7371cc4a3af2ca9e1a646a5a3684e9ecb64ae28 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Thu, 3 Oct 2024 16:59:33 +0100 Subject: [PATCH 13/15] Fix code smell --- deploy/scripts/src/cri-orange/nino-check.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index e0d33f94..fc989eed 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -85,12 +85,11 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { export function setup(): void { describeProfile(loadProfile) - let imposterstarted = false + const imposterstarted = false if (!imposterstarted) { const response = imposter.handler() console.log('Response status: ', response[0].status) console.log('Response body: ', response[0].body) - imposterstarted = true } } From 97fbaed22b891a1a03aea58dbdbd9a117ac380f1 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Thu, 3 Oct 2024 17:03:00 +0100 Subject: [PATCH 14/15] Fix linting issue --- deploy/scripts/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/scripts/README.md b/deploy/scripts/README.md index 097820f1..8c87089f 100644 --- a/deploy/scripts/README.md +++ b/deploy/scripts/README.md @@ -103,7 +103,7 @@ Parameter store locations must start with the prefix `/perfTest/` in order for t |`SCENARIO`|`all`[_default_]
`sign_in`
`create_account,sign_in`|Comma seperated list of scenarios to enable. Blank strings or `'all'` will default to enabling all scenarios in the selected load profile. Implementation in [`getScenarios`](src/common/utils/config/load-profiles.ts#L27-L36) function| |`ENVIRONMENT`|`build`[_default_]
`staging`|Name of the environment where the test is being conducted. Accepted Values are build/staging depending on the test scenario| -Note: To overcome latency issues caused by lambda cold starts, a [lambda warmer script](src/common/lambda-warmer.ts) is ran before performance tests. This sends concurrent requests to the respective imposter stub. +Note: To overcome latency issues caused by lambda cold starts, a [lambda warmer script](src/common/lambda-warmer.ts) is ran before performance tests. This sends concurrent requests to the respective imposter stub. 5. Click 'Start Build' From 9fbf6856871b00d209630e55f0b0293a834f0d86 Mon Sep 17 00:00:00 2001 From: Abhinay Srivastava <117734822+abhinaysrivastavaperf@users.noreply.github.com> Date: Fri, 4 Oct 2024 15:00:01 +0100 Subject: [PATCH 15/15] Remove unused assignment variable and if condition --- deploy/scripts/src/cri-orange/nino-check.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/deploy/scripts/src/cri-orange/nino-check.ts b/deploy/scripts/src/cri-orange/nino-check.ts index fc989eed..71973c53 100644 --- a/deploy/scripts/src/cri-orange/nino-check.ts +++ b/deploy/scripts/src/cri-orange/nino-check.ts @@ -85,12 +85,9 @@ const csvData1: Nino[] = new SharedArray('csvDataNino', () => { export function setup(): void { describeProfile(loadProfile) - const imposterstarted = false - if (!imposterstarted) { - const response = imposter.handler() - console.log('Response status: ', response[0].status) - console.log('Response body: ', response[0].body) - } + const response = imposter.handler() + console.log('Response status: ', response[0].status) + console.log('Response body: ', response[0].body) } export function ninoCheck(): void {