-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Add 'Unknown' wh type for EOL/critmass states #188
Comments
You and me both, dude! I think the quickest solution to this one is to have a We can technically add it as a I'm not so sure I'd have it as an actual node on the map taking up space for no valid reason. Would you agree that the above is sufficient? |
I suggest adding new node on map because I think it's technically easier to implement, to reuse current functionality with color-rendering signature on system type in signatures module (pic below). To not take much space, new node can be much smaller because it has no info, just text or even icon. Your approach is ok, too. So, currently it renders like: You suggest to add new buttons here (when clicking 'unknown' in 'leads to' column) ? If so, in case of valid connection to other system, implementation should set these states (EOL, critmass) to actual connection. Or don't show buttons for existing connection. Note that there's rendering option for 'reduced' wh size (in yellow), may be it will be better to add this variant, too. I'm not good with JS and code base here, so may be you know what is better approach for existing code. |
Also may be this issue should be linked with #159 ? |
Would love to see this implemented as well. Constantly come up against the same dilemma as OP, and have to resort to using the description box to mark it EOL for now. |
Hey team, so is the solution just to have an "unknown" option in that drop-down? |
Living in WH-space we usually have following scenario:
Currently I'm just writing this information in description of signature, but it would be more visually preferable to see 'Unknown' wh on the map with connection, marked appropriately. Alternatively I can use random system with name alias 'Unknown', but it is a workaround and has drawbacks (incorrect system type and statics). It will be more convenient to have separate 'Unknown' WH type.
The text was updated successfully, but these errors were encountered: