Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pervasive use of OsString causes problems for wasm #1215

Open
simoncozens opened this issue Jan 24, 2025 · 0 comments
Open

Pervasive use of OsString causes problems for wasm #1215

simoncozens opened this issue Jan 24, 2025 · 0 comments

Comments

@simoncozens
Copy link
Contributor

fontc uses fontbe which uses fea-rs which has a structure Source which stores feature file paths as OsStrings. fea-rs uses the serde feature to serialize these paths for fontbe to do persistable job orchestration.

However, serde does not implement Serialize and Deserialise for OsStrings on the WASM platform, only Unix and Windows, so the whole thing falls down. We could replace it all with Strings to work everywhere.

Additionally, fontbe/src/feature.rs has the concept of an InMemoryResolver which sounds perfect for things which don't have filesystems! Except that it also stores content_path: OsString, which makes it dependent on filesystems again.

@simoncozens simoncozens changed the title Pervasive of OsString causes problems for wasm Pervasive use of OsString causes problems for wasm Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant