From 46d3580f743aae97886fded9a5847353b5fb7707 Mon Sep 17 00:00:00 2001
From: Julie Qiu <julie@golang.org>
Date: Fri, 1 Nov 2024 10:58:14 -0400
Subject: [PATCH] fix: remove read from os.Stdin

cmd/openapi always reads from a file, so remove the option to read from
stdin, and fail if no input is provided.
---
 generator/cmd/openapi/main.go | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/generator/cmd/openapi/main.go b/generator/cmd/openapi/main.go
index c465ff2e7..3a2f0f653 100644
--- a/generator/cmd/openapi/main.go
+++ b/generator/cmd/openapi/main.go
@@ -16,7 +16,6 @@ package main
 
 import (
 	"flag"
-	"io"
 	"log"
 	"log/slog"
 	"os"
@@ -32,9 +31,11 @@ func main() {
 	templateDir := flag.String("template-dir", "templates/", "the path to the template directory")
 	flag.Parse()
 
+	if *inputPath == "" {
+		log.Fatalf("must provide input-path")
+	}
 	if err := run(*inputPath, *language, *outDir, *templateDir); err != nil {
 		log.Fatal(err)
-		os.Exit(1)
 	}
 	slog.Info("Generation Completed Successfully")
 }
@@ -44,16 +45,9 @@ func run(inputPath, language, outDir, templateDir string) error {
 		contents []byte
 		err      error
 	)
-	if inputPath == "" {
-		contents, err = io.ReadAll(os.Stdin)
-		if err != nil {
-			return err
-		}
-	} else {
-		contents, err = os.ReadFile(inputPath)
-		if err != nil {
-			return err
-		}
+	contents, err = os.ReadFile(inputPath)
+	if err != nil {
+		return err
 	}
 	return generateFrom(contents, language, outDir, templateDir)
 }
@@ -71,10 +65,8 @@ func generateFrom(contents []byte, language, outDir, templateDir string) error {
 	if err != nil {
 		return err
 	}
-
 	if _, err := genclient.Generate(req); err != nil {
 		return err
 	}
-
 	return nil
 }