Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate unit tests hosted in src/wkt/tests/timestamp.rs into wkt/src/timestamp.rs #573

Open
mpeddada1 opened this issue Jan 2, 2025 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@mpeddada1
Copy link
Collaborator

mpeddada1 commented Jan 2, 2025

Context:

Thanks for the context, from reading https://doc.rust-lang.org/book/ch11-03-test-organization.html#:~:text=The%20purpose%20of%20unit%20tests,code%20that%20they're%20testing, it looks like the tests/ file is reserved for integration tests?

Unit tests are small and more focused, testing one module in isolation at a time, and can test private interfaces. Integration tests are entirely external to your library and use your code in the same way any other external code would, using only the public interface and potentially exercising multiple modules per test.

We have a few other tests (like convert_from_time) that might belong in the wkt/src/timestamp.rs. I'll create a follow up to move them.

Originally posted by @mpeddada1 in #559 (comment)

cc/ @coryan

@mpeddada1 mpeddada1 added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant