Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reactor Bindings #1296

Open
gkatzioura opened this issue Oct 5, 2023 · 3 comments · May be fixed by #1297
Open

Add reactor Bindings #1296

gkatzioura opened this issue Oct 5, 2023 · 3 comments · May be fixed by #1297
Assignees
@TimurSadykov
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gkatzioura
Copy link

Is your feature request related to a problem? Please describe.
In order to integrate with reactive apps, you have to either execute blocking calls using Mono.fromCallable or create an implementation based on WebClient.

Describe the solution you'd like
A reactive binding of google-auth-library based on WebClient. The implementation would be re-usable for other cloud component's apis. The authentication token generation and the api call creation could be used to make more functionalities reactive.

Describe alternatives you've considered
quarkus

Additional context
This is related to an issue and PR on the spring-cloud-gcp projec
GoogleCloudPlatform/spring-cloud-gcp#2027
GoogleCloudPlatform/spring-cloud-gcp#2028
This was referenced Oct 5, 2023
Closed
Closed
Open
@brianmaresca
Copy link

Figured I would add this to further emphasize how valuable I believe this issue/request is. From the cloud run docs https://cloud.google.com/run/docs/tips/java#write_non-blocking_reactive_code_to_optimize_memory_and_startup:
To truly reduce the number of threads, consider adopting a non-blocking reactive programming model, so that the number of threads can be significantly reduced while handling more concurrent requests. Application frameworks like Spring Boot with Webflux, Micronaut, and Quarkus support reactive web applications.

This is ironic to me - the docs themselves suggest using reactive code yet there is very little reactive support across the java google libraries.

@TimurSadykov
Copy link
Contributor

@gkatzioura @brianmaresca Thanks for raising the issue and proposal. We will take a look.

@TimurSadykov TimurSadykov self-assigned this Oct 5, 2023
@TimurSadykov TimurSadykov added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 5, 2023
@gkatzioura
Copy link
Author

Relevant pr
#1297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimurSadykov TimurSadykov

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1296: Added reactive binding gkatzioura/google-auth-library-java
3 participants
@gkatzioura @TimurSadykov @brianmaresca