Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance concern on observing all Video node fields #5

Open
jeanbenitezu opened this issue Apr 20, 2023 · 0 comments
Open

Performance concern on observing all Video node fields #5

jeanbenitezu opened this issue Apr 20, 2023 · 0 comments

Comments

@jeanbenitezu
Copy link

jeanbenitezu commented Apr 20, 2023

Hi Google Ads Team!

I have a concern with performance here, this line is attaching an observer for each video node field, and they are a lot, and even worst, some of them are content nodes, so when something on these nodes changes, it may trigger the observer.

My question is: is it necessary in that way?

I made some small changes just to observe a limited number of fields and, it seems it works in the same way as observing all the fields

["position", "state", "control", "timedMetaData", "timedMetaData2"]

What do you recommend?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant