From f9e7ee10aae408259b39537a18bf5c57bf3da179 Mon Sep 17 00:00:00 2001
From: Chris Leary <cdleary@openai.com>
Date: Thu, 23 Jan 2025 11:02:02 -0800
Subject: [PATCH] [DSLX:RR][cleanup] Rename failures to GetFailureMessages per
 cpp style (lowercase should be simple accessors that do no work).

---
 xls/dslx/run_routines/run_routines.h       | 2 +-
 xls/dslx/run_routines/run_routines_test.cc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xls/dslx/run_routines/run_routines.h b/xls/dslx/run_routines/run_routines.h
index 23c0f82f72..492a43e4b5 100644
--- a/xls/dslx/run_routines/run_routines.h
+++ b/xls/dslx/run_routines/run_routines.h
@@ -169,7 +169,7 @@ class TestResultData {
     test_cases_.push_back(std::move(test_case));
   }
 
-  std::vector<std::string> failures() {
+  std::vector<std::string> GetFailureMessages() const {
     std::vector<std::string> failures;
     for (const auto& test_case : test_cases_) {
       if (test_case.status == test_xml::RunStatus::kRun &&
diff --git a/xls/dslx/run_routines/run_routines_test.cc b/xls/dslx/run_routines/run_routines_test.cc
index 63f9aba118..bf064783d2 100644
--- a/xls/dslx/run_routines/run_routines_test.cc
+++ b/xls/dslx/run_routines/run_routines_test.cc
@@ -529,7 +529,7 @@ proc tester_proc {
       TestResultData result,
       ParseAndTest(kProgram, "test_module", "test.x", options));
 
-  auto failures = result.failures();
+  std::vector<std::string> failures = result.GetFailureMessages();
   EXPECT_EQ(failures.size(), 1);
   if (GetParam() == RunnerType::kDslxInterpreter) {
     EXPECT_THAT(failures[0],