Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Switch to using gRPC-Web for Reviewer #289

Open
oferb opened this issue Sep 11, 2018 · 7 comments
Open

Switch to using gRPC-Web for Reviewer #289

oferb opened this issue Sep 11, 2018 · 7 comments

Comments

@oferb
Copy link
Contributor

oferb commented Sep 11, 2018

This includes both local_server and front-end code.

@oferb oferb added the P2 label Sep 11, 2018
@oferb
Copy link
Contributor Author

oferb commented Sep 11, 2018

@oferb
Copy link
Contributor Author

oferb commented Sep 14, 2018

If you want this as a first issue, let us know and we'll explain it better.
There's a working example to follow: https://github.com/oferb/startup-os-example/tree/master/app

@oferb oferb added the good first issue Good for newcomers label Sep 14, 2018
@wilder
Copy link
Contributor

wilder commented Oct 1, 2018

I would like to work on this. How can I proceed?

@oferb
Copy link
Contributor Author

oferb commented Oct 1, 2018

Hey! Welcome :)
So the first step is to get this example running:
https://github.com/oferb/startup-os-example/tree/master/app
and also ./build.sh and ./test.sh from this repo.

Then, take a look at the steps here:
https://github.com/oferb/startup-os-example/blob/master/app/run_sample.sh

What you want to do, is have the proxy run against this gRPC server:
https://github.com/google/startup-os/blob/master/tools/reviewer/local_server/local_server.sh
That's the main challenge.

Let me know how it goes!

@elinabtl
Copy link

elinabtl commented Oct 4, 2018

How's it going?

@wilder
Copy link
Contributor

wilder commented Oct 4, 2018

@elinabtl I haven't started working on it yet, I was planning to do it only during the weekend.
Feel free to do it if you want to!

@oferb
Copy link
Contributor Author

oferb commented Oct 4, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants