Support for a flag to inject environment variables #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new flag that will take defaults from environment variables if available. The variable is lookedup as the parameter and full upercase for convenience.
mariocj89
changed the title
|
Thanks for the PR! |
|
No thanks needed! |
|
Is this PR going to be merged? I'm looking forward to using this feature. |
|
I am happy to do any requested change :) @dbieber let me know if there is anything to change |
|
I guess this is not going to happen |
|
It is a sad day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option that will take defaults from environment variables if available.
The variable is looked up as the parameter and full uppercase for convenience.
The option use_environment can be used both as a flag or a value can be passed in which allows to set a prefix for the env variables to look for. (Check the tests)
I'm not totally convinced on how the variable is passed around the code. Open to suggestions.
Happy to add docs once we finalise all decisions.
Fixes #94