Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: avoid "unknown" in list_targets #2441

Open
eustas opened this issue Jan 16, 2025 · 1 comment
Open

FR: avoid "unknown" in list_targets #2441

eustas opened this issue Jan 16, 2025 · 1 comment

Comments

@eustas
Copy link
Contributor

eustas commented Jan 16, 2025

Here is what I see, when I build libjxl on s390x:

Compiled HWY_TARGETS:   EMU128
HWY_ATTAINABLE_TARGETS: EMU128
HWY_BASELINE_TARGETS:   EMU128
HWY_STATIC_TARGET:      EMU128
HWY_BROKEN_TARGETS:    
HWY_DISABLED_TARGETS:   Unknown Unknown Unknown Unknown Unknown Unknown Unknown Unknown Unknown
Current CPU supports:   Z15 Z14 EMU128 SCALAR

There is a long list in disabled targets and no clues why Z14 / Z15 are not compiled.

@jan-wassenberg
Copy link
Member

Thanks for raising this. The Unknown are because TargetName only returns a string when HWY_ARCH* matches the architecture of that target. I see that JPEG XL defines 8 non-S390 targets in HWY_DISABLED_TARGET. That almost explains this: we have 9x Unknown here.

I suppose we can remove those #if to print the actual target names, would that help?

As to building Z14/Z15: this requires Clang 19(!) or GCC 9.
Note also that HWY_ATTAINABLE_S390X is gated on #if HWY_ARCH_S390X && HWY_BASELINE_Z14 != 0. Would you like to try changing the second condition to HWY_HAVE_RUNTIME_DISPATCH? Otherwise, we'd have to build with the Z14 flags.

HTH?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants