Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the src/layers/rnn_cell.py #17

Open
JLiu-1 opened this issue Dec 6, 2021 · 0 comments
Open

About the src/layers/rnn_cell.py #17

JLiu-1 opened this issue Dec 6, 2021 · 0 comments

Comments

@JLiu-1
Copy link

JLiu-1 commented Dec 6, 2021

In the call() function of EideticLSTMCell class, on line 210 and line 215 there are:
output_gate = tf.tanh(o_x + o_h + o_c + o_m)
output = tf.tanh(memory) * tf.sigmoid(output_gate)
However, according to the paper, I think these 2 lines should be:
output_gate = tf.sigmoid(o_x + o_h + o_c + o_m)
output = tf.tanh(memory) * output_gate
Are there any explanations that there's and additional tanh activation on the (o_x + o_h + o_c + o_m)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant