Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Enhanced L2CAP mode to support GOEB #245

Open
akuker opened this issue Aug 13, 2023 · 6 comments
Open

Add support for Enhanced L2CAP mode to support GOEB #245

akuker opened this issue Aug 13, 2023 · 6 comments

Comments

@akuker
Copy link
Contributor

akuker commented Aug 13, 2023

For my use case, I would like to be able to use the Generic Object Exchange Profile (GOEP). According to the GOEP specification, the L2CAP channel must be configured for Enhanced Retransmission Mode:

7.1.2 Flow and Error Control Option
The L2CAP channel for OBEX connections shall be configured to use Enhanced Retransmission Mode

The current l2cap implementation in Bumble only supports Basic flow/control mode and does not support Enhanced Retransmission Mode. Therefore will not support GOEP functions. Please update the l2cap implementation (and test cases) to support ERTM.

@akuker
Copy link
Contributor Author

akuker commented Aug 13, 2023

Note: I'm working on this issue and hope to have a PR soon. Feel free to assign it to me.

@barbibulle
Copy link
Collaborator

FYI, we will likely soon do a bit of refactoring/cleanup in the way L2CAP is handled. I hope that won't conflict too much with your work.

@akuker
Copy link
Contributor Author

akuker commented Aug 21, 2023

FYI, we will likely soon do a bit of refactoring/cleanup in the way L2CAP is handled. I hope that won't conflict too much with your work.

Will the interfaces to the class be changing?

@Crucio32000
Copy link

FYI, we will likely soon do a bit of refactoring/cleanup in the way L2CAP is handled. I hope that won't conflict too much with your work.

Hi, this topic is not updated since last year.
There is any planned release in the near future, that implements the refactor you were mentioning ?

Thank you for your work!

@zxzxwu
Copy link
Collaborator

zxzxwu commented Sep 21, 2024

I have a PoC prototype, but I found it's not very compatible with the original implementation, so I am still thinking how to resolve this.

BTW, if you want to use GOEP, you may just use GOEP 1.1 which is based on RFCOMM.

@zxzxwu
Copy link
Collaborator

zxzxwu commented Sep 21, 2024

The refactor has completed. You may feel free to contribute. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants