Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitch with right-aligned inline inputs (Thrasos) #8595

Open
1 task done
mikeharv opened this issue Sep 26, 2024 · 1 comment
Open
1 task done

Glitch with right-aligned inline inputs (Thrasos) #8595

mikeharv opened this issue Sep 26, 2024 · 1 comment
Labels
issue: bug Describes why the code or behaviour is wrong needs more info Waiting for developer response

Comments

@mikeharv
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

If a value input is set with a right alignment (e.g. 'procedures_defreturn') and inline inputs, the connection will move back and forth as it attempts to fit the insertion marker.

Reproduction steps

  1. Open the Advanced Blockly Playground
  2. Switch to the Thrasos renderer
  3. Drag a function with return block to the workspace.
  4. Use the context menu to set the inputs to be inline.
  5. Attempt to drag a wide math expression block into the value input.

Stack trace

No response

Screenshots

2024-09-26 09-53-56 2024-09-26 09_54_32

Browsers

No response

@mikeharv mikeharv added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Sep 26, 2024
@cpcallen
Copy link
Contributor

This is definitely a valid bug report, but we're not sure how to change Blockly's behaviour to fix it.

It is caused by a particular combination of circumstances:

  • Using a renderer that uses insertion markers instead of a replacement glow for value inputs.
  • The input has to be inline and right aligned.
  • It has to be in a block with a substantially wider input in a different row.
  • The block(s) being dragged in need to be somewhat wide.

…and is governed by various settings (e.g. drag radii) that were introduced and tuned to make dragging feel fairly natural and intuitive in most cases.

We think you can resolve the user-facing issue by avoiding this particular combination of circumstances. We're happy to take suggestions about how Blockly should behave in these circumstances, noting the existing insertion marker algorithms.

@cpcallen cpcallen added needs more info Waiting for developer response and removed issue: triage Issues awaiting triage by a Blockly team member labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong needs more info Waiting for developer response
Projects
None yet
Development

No branches or pull requests

2 participants