Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire workspace comment resize events #8113

Closed
1 task
BeksOmega opened this issue May 14, 2024 · 2 comments · Fixed by #8217
Closed
1 task

Fire workspace comment resize events #8113

BeksOmega opened this issue May 14, 2024 · 2 comments · Fixed by #8217
Assignees
@johnnesky
Labels
issue: feature request Describes a new feature and why it should be added

Comments

@BeksOmega
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

Currently we don't do this and it wasn't planned, but it might be nice to fire resize events for workspace comments. Main use-case being RTC

Request

Fire an event with the old size and the new size of the workspace comments after a resize.

Alternatives considered

No response

Additional context

No response
@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels May 14, 2024
@maribethb
Copy link
Contributor

@johnnesky this is the issue in core to fire resize events for workspace comments if you're interested

@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label May 31, 2024
@johnnesky johnnesky self-assigned this May 31, 2024
@johnnesky
Copy link
Member

Thanks. Related to google/blockly-samples#2330

@gonfunko gonfunko mentioned this issue Jun 11, 2024
Merged
@johnnesky johnnesky mentioned this issue Jun 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnnesky johnnesky

Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Drag and Resize events for workspace comments johnnesky/blockly
3 participants
@maribethb @BeksOmega @johnnesky