-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In rc/v11.0.0 you can't redo drag changes that disable blocks #7951
Labels
issue: bug
Describes why the code or behaviour is wrong
Comments
johnnesky
added
issue: bug
Describes why the code or behaviour is wrong
issue: triage
Issues awaiting triage by a Blockly team member
labels
Mar 19, 2024
See also: #7958 |
maribethb
removed
the
issue: triage
Issues awaiting triage by a Blockly team member
label
Mar 27, 2024
NeilFraser
added a commit
that referenced
this issue
Apr 24, 2024
There's no need to record and replay these events since the change will happen automatically anyway. Resolves #7951
NeilFraser
added a commit
that referenced
this issue
Apr 24, 2024
There's no need to record and replay these events since the change will happen automatically anyway. Resolves #7951
NeilFraser
added a commit
that referenced
this issue
Apr 29, 2024
There's no need to record and replay these events since the change will happen automatically anyway. Resolves #7951 # Conflicts: # blocks/loops.ts # blocks/procedures.ts
NeilFraser
added a commit
that referenced
this issue
Apr 30, 2024
NeilFraser
added a commit
that referenced
this issue
May 7, 2024
There's no need to record and replay these events since the change will happen automatically anyway. Resolves #7951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for duplicates
Description
The
controls_flow_statements
and theprocedures_ifreturn
blocks are automatically disabled if they are dragged outside of any loop or procedure definition, respectively. In therc/v11.0.0
branch, such a drag change can be undone, but not redone. In fact, if such a change is performed, all previous changes in the undo history cannot be redone.Drag changes that enable blocks seem to be fine. Only drag changes that disable blocks cause the bug.
Reproduction steps
rc/v11.0.0
branch.npm run start
to view the playground.controls_flow_statements
block into the workspace. It will be disabled.controls_repeat_ext
block into the workspace separately.controls_flow_statements
block into thecontrols_repeat_ext
block as a child. It will become enabled (At this point, the changes so far are undoable and redoable.)controls_flow_statements
block back out of thecontrols_repeat_ext
block. It will become disabled again.Stack trace
No response
Screenshots
No response
Browsers
Chrome desktop
The text was updated successfully, but these errors were encountered: