Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In rc/v11.0.0 you can't redo drag changes that disable blocks #7951

Closed
1 task done
johnnesky opened this issue Mar 19, 2024 · 1 comment · Fixed by #8049
Closed
1 task done

In rc/v11.0.0 you can't redo drag changes that disable blocks #7951

johnnesky opened this issue Mar 19, 2024 · 1 comment · Fixed by #8049
Assignees
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@johnnesky
Copy link
Member

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

The controls_flow_statements and the procedures_ifreturn blocks are automatically disabled if they are dragged outside of any loop or procedure definition, respectively. In the rc/v11.0.0 branch, such a drag change can be undone, but not redone. In fact, if such a change is performed, all previous changes in the undo history cannot be redone.

Drag changes that enable blocks seem to be fine. Only drag changes that disable blocks cause the bug.

Reproduction steps

  1. Check out the rc/v11.0.0 branch.
  2. Run npm run start to view the playground.
  3. Drag a controls_flow_statements block into the workspace. It will be disabled.
  4. Drag a controls_repeat_ext block into the workspace separately.
  5. Drag the controls_flow_statements block into the controls_repeat_ext block as a child. It will become enabled (At this point, the changes so far are undoable and redoable.)
  6. Drag the controls_flow_statements block back out of the controls_repeat_ext block. It will become disabled again.
  7. Undo.
  8. Attempt to redo. It won't work.
  9. You can undo a few more steps but you won't be able to redo them.

Stack trace

No response

Screenshots

No response

Browsers

Chrome desktop

@johnnesky johnnesky added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Mar 19, 2024
@johnnesky johnnesky mentioned this issue Mar 23, 2024
1 task
@johnnesky
Copy link
Member Author

See also: #7958

@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label Mar 27, 2024
@NeilFraser NeilFraser self-assigned this Apr 18, 2024
NeilFraser added a commit that referenced this issue Apr 24, 2024
There's no need to record and replay these events since the change will happen automatically anyway.

Resolves #7951
NeilFraser added a commit that referenced this issue Apr 24, 2024
There's no need to record and replay these events since the change will happen automatically anyway.

Resolves #7951
NeilFraser added a commit that referenced this issue Apr 29, 2024
There's no need to record and replay these events since the change will happen automatically anyway.

Resolves #7951

# Conflicts:
#	blocks/loops.ts
#	blocks/procedures.ts
NeilFraser added a commit that referenced this issue Apr 30, 2024
There's no need to record and replay these events since the change will happen automatically anyway.

Related to #7951 and #7950.
NeilFraser added a commit that referenced this issue May 7, 2024
There's no need to record and replay these events since the change will happen automatically anyway.

Resolves #7951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
3 participants