Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't disable if-return block inside procedure definition #1390

Closed
3 of 10 tasks
vicng opened this issue Oct 26, 2017 · 2 comments
Closed
3 of 10 tasks

Can't disable if-return block inside procedure definition #1390

vicng opened this issue Oct 26, 2017 · 2 comments
Assignees
@johnnesky
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong low priority

Comments

@vicng
Copy link
Contributor

vicng commented Oct 26, 2017 •
edited
Loading

Problem statement

  • Bug report
  • Feature request

An "if-return" block can't be disabled once it's connected to a procedure block.

Expected Behavior

It should be disabled.

Actual Behavior

It remains enabled.

Steps to Reproduce

  1. Drag procedure definition into block to workspace.
  2. Connect if-return block to it.
  3. Right-click on the if-return block and select "Disable block".

Stack Traces

No errors in console.

Operating System and Browser

  • Desktop:
    • Chrome
    • Firefox
    • Safari
    • Opera
    • IE 10+
    • IE 11
    • EDGE
@vicng vicng added the issue: bug Describes why the code or behaviour is wrong label Oct 26, 2017
@samelhusseini
Copy link
Contributor

I think for this we should add a canBeDisabled property on a Blockly.Block, and only show the context menu if that property is true. The procedures_if_return block should set canBeDisabled to false.

@samelhusseini samelhusseini added help wanted External contributions actively solicited low priority labels Jan 16, 2020
@samelhusseini samelhusseini mentioned this issue Jan 16, 2020
Closed
2 tasks
@johnnesky johnnesky self-assigned this Mar 23, 2024
@johnnesky johnnesky mentioned this issue Mar 23, 2024
Merged
1 task
@johnnesky
Copy link
Member

Fixed by: #7958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnnesky johnnesky

Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vicng @samelhusseini @johnnesky